Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd: 1.4.4 -> 1.4.5 #88609

Merged
merged 1 commit into from May 23, 2020
Merged

zstd: 1.4.4 -> 1.4.5 #88609

merged 1 commit into from May 23, 2020

Conversation

@orivej
Copy link
Contributor

orivej commented May 22, 2020

Motivation for this change

A regular update with improved decompression speed.

The previous CMake version did not run any tests, the current version tries to run all tests (I could not await their completion), and the last GNU Make version ran make -C tests shortest which ran only playTests.sh, so I've enabled only the playTests test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@orivej orivej force-pushed the orivej:zstd branch 3 times, most recently from 7f1c6f9 to 5fe56b0 May 23, 2020
@nh2
nh2 approved these changes May 23, 2020
The previous CMake version did not run any tests, and the last GNU
Make version ran `make -C tests shortest` which ran only playTests.sh.
@orivej orivej force-pushed the orivej:zstd branch from 5fe56b0 to 6eb2a76 May 23, 2020
@orivej-nixos
Copy link
Contributor

orivej-nixos commented May 23, 2020

The tests have failed on Darwin due to an inconsistency in stat arguments. I have added a patch that should help.

@orivej-nixos orivej-nixos merged commit 6817991 into NixOS:master May 23, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6eb2a76"; rev="6eb2a765fca0e2cc174a1c86dd437720873c4089"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6eb2a76"; rev="6eb2a765fca0e2cc174a1c86dd437720873c4089"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6eb2a76"; rev="6eb2a765fca0e2cc174a1c86dd437720873c4089"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6eb2a76"; rev="6eb2a765fca0e2cc174a1c86dd437720873c4089"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6eb2a76"; rev="6eb2a765fca0e2cc174a1c86dd437720873c4089"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6eb2a76"; rev="6eb2a765fca0e2cc174a1c86dd437720873c4089"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6eb2a76"; rev="6eb2a765fca0e2cc174a1c86dd437720873c4089"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
zstd, zstd.passthru.tests on aarch64-linux Success
Details
zstd, zstd.passthru.tests on x86_64-darwin Success
Details
zstd, zstd.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.