Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix secp256k1 broken package #88612

Merged
merged 3 commits into from May 28, 2020
Merged

fix secp256k1 broken package #88612

merged 3 commits into from May 28, 2020

Conversation

@Avzgui
Copy link
Contributor

Avzgui commented May 22, 2020

The way setup_version is checked generated errors. I fixed it via postPatch by using string comparison (don't know if it's optimal).

@Avzgui
Copy link
Contributor Author

Avzgui commented May 23, 2020

After reflection, I think it's more relevant to add something like:

substituteInPlace setup.py --replace "int(i)" "int(i) if i.isdigit() else 0"

Instead of:

substituteInPlace setup.py --replace "[int(i) for i in setuptools_version.split('.')] < [3, 3]" "setuptools_version < '3.3'"
@FRidh
Copy link
Member

FRidh commented May 23, 2020

Please just patch that nonsense out entirely. Setuptools 3.3 is 6 years old.

@Avzgui
Copy link
Contributor Author

Avzgui commented May 23, 2020

Well, I can't disagree with that.

Copy link
Contributor

chris-martin left a comment

The sed patch seems fragile, but seems harmless enough since the python package hasn't been updated since 2016.

@jonringer jonringer merged commit 847de99 into NixOS:master May 28, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cef0d5d"; rev="cef0d5da1223fda642379b06476774cb9b181d4a"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cef0d5d"; rev="cef0d5da1223fda642379b06476774cb9b181d4a"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cef0d5d"; rev="cef0d5da1223fda642379b06476774cb9b181d4a"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cef0d5d"; rev="cef0d5da1223fda642379b06476774cb9b181d4a"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cef0d5d"; rev="cef0d5da1223fda642379b06476774cb9b181d4a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cef0d5d"; rev="cef0d5da1223fda642379b06476774cb9b181d4a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cef0d5d"; rev="cef0d5da1223fda642379b06476774cb9b181d4a"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer
Copy link
Contributor

jonringer commented May 28, 2020

I squashed the commits for you, but please adhere to CONTRIBUTING.md guidelines about git history.

Also, thanks for opening your first PR against nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.