Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen-oath-safe: add dependency on file command #88629

Open
wants to merge 1 commit into
base: master
from

Conversation

@wamserma
Copy link
Contributor

wamserma commented May 22, 2020

Motivation for this change

file was not listed as a dependency, causing the program to throw an error.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@wamserma
Copy link
Contributor Author

wamserma commented May 23, 2020

@grahamc OfBorg seems stuck on "Fetching PR" - is this caused by GitHub being a bit wobbly yesterday or simply high load on OfBorg?

@wamserma
Copy link
Contributor Author

wamserma commented Jun 4, 2020

ping @makefu (maintainer)

@makefu
makefu approved these changes Jun 5, 2020
Copy link
Contributor

makefu left a comment

LGTM

@wamserma
Copy link
Contributor Author

wamserma commented Jun 15, 2020

@FRidh merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.