Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastd: v18 -> v19 #88630

Merged
merged 3 commits into from May 23, 2020
Merged

fastd: v18 -> v19 #88630

merged 3 commits into from May 23, 2020

Conversation

@mweinelt
Copy link
Member

mweinelt commented May 22, 2020

Motivation for this change

New upstream release. The repository moved to GitHub.

https://fastd.readthedocs.io/en/stable/releases/v19.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fpletz

@doronbehar
Copy link
Contributor

doronbehar commented May 23, 2020

Why unicode!? This prevents our bot from putting the right labels to your PR.

Co-authored-by: Doron Behar <doron.behar@gmail.com>
@Mic92 Mic92 changed the title fastd: v18 → v19 fastd: v18 -> v19 May 23, 2020
@Mic92 Mic92 merged commit 1a095f7 into NixOS:master May 23, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Checking new out paths
Details
@ofborg ofborg bot requested a review from fpletz May 23, 2020
@cole-h
Copy link
Member

cole-h commented May 23, 2020

FYI: Unicode arrows do not affect the bot's functionality in any way. IIRC, we look for a colon and then split on that to get the package attribute -- we don't care about anything past that colon (though this is probably how we'd implement automatically adding the 8.has: package (update) label). However, the contributor's guide itself suggests -> be used, so it would be nice if we could all stick to that convention 😉

The real reason evaluations didn't start originally was because of a missing enum variant when dealing with GitHub's API; this has since been fixed.

Side note: ofborg does not look at PR titles, but commit titles.

@mweinelt mweinelt deleted the mweinelt:fastd branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.