Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: CONFIG_MOUSE_ELAN_I2C_SMBUS=y #88646

Open
wants to merge 1 commit into
base: master
from

Conversation

@andersk
Copy link
Contributor

andersk commented May 23, 2020

Motivation for this change

Without CONFIG_MOUSE_ELAN_I2C_SMBUS, the kernel warns

psmouse serio1: elantech: The touchpad can support a better bus than the too old PS/2 protocol. Make sure MOUSE_PS2_ELANTECH_SMBUS and MOUSE_ELAN_I2C_SMBUS are enabled to get a better touchpad experience.

and it is quite correct, at least on this laptop (ThinkPad Yoga 14 20FY), where CONFIG_MOUSE_ELAN_I2C_SMBUS=y in conjunction with boot.extraModprobeConfig="options psmouse elantech_smbus=1" are necessary to eliminate an annoying sticky touchpad button issue.

CONFIG_MOUSE_ELAN_I2C_SMBUS is enabled in Arch, CentOS, Fedora, and Ubuntu. (Debian lacks its prerequisite CONFIG_MOUSE_ELAN_I2C entirely.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.