Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird, thunderbird-bin: 68.8.0 -> 68.8.1 #88657

Merged
merged 2 commits into from May 24, 2020

Conversation

@taku0
Copy link
Contributor

taku0 commented May 23, 2020

Motivation for this change
  • Bug fixes

https://www.thunderbird.net/en-US/thunderbird/68.8.1/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

lovesegfault left a comment

WFM

@vcunat
vcunat approved these changes May 24, 2020
Copy link
Member

vcunat left a comment

Both work fine for me. The release notes are minimal.

@vcunat vcunat merged commit fa4e5b5 into NixOS:master May 24, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a9a8ba3"; rev="a9a8ba3db529b0b1499c5643040036fba61d35fa"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a9a8ba3"; rev="a9a8ba3db529b0b1499c5643040036fba61d35fa"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a9a8ba3"; rev="a9a8ba3db529b0b1499c5643040036fba61d35fa"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a9a8ba3"; rev="a9a8ba3db529b0b1499c5643040036fba61d35fa"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a9a8ba3"; rev="a9a8ba3db529b0b1499c5643040036fba61d35fa"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a9a8ba3"; rev="a9a8ba3db529b0b1499c5643040036fba61d35fa"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a9a8ba3"; rev="a9a8ba3db529b0b1499c5643040036fba61d35fa"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
thunderbird, thunderbird-bin, thunderbird-bin.passthru.tests, thunderbird.passthru.tests on aarch64-linux Success
Details
thunderbird, thunderbird-bin, thunderbird-bin.passthru.tests, thunderbird.passthru.tests on x86_64-linux Success
Details
vcunat added a commit that referenced this pull request May 24, 2020
(cherry picked from commit fa4e5b5)
I re-tested both briefly on 20.03.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.