Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.no-title-bar: unbreak, 9 -> 2020-05-14 #88679

Open
wants to merge 1 commit into
base: master
from

Conversation

@maxeaubrey
Copy link
Contributor

maxeaubrey commented May 23, 2020

Motivation for this change

Version in nix has been unmaintained but a fork has had updates for the last two gnome versions - could be backported to 20.03 as well to unbreak there - I've been using it since January and it works fine.

No tags upstream so switched to a revision and changed version to a date. Not sure if I've gone the right way about all of the things in the nixpkg though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
9 -> 2020-05-14
Switches to a supported fork, updates patches as necessary
Copy link
Member

endocrimes left a comment

LGTM

@bjornfor
Copy link
Contributor

bjornfor commented May 30, 2020

I'd be nice to ask upstream to make a release. (I personally don't like packaging unreleased software.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.