Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno: 1.0.0 -> 1.0.5 #88681

Draft
wants to merge 1 commit into
base: master
from
Draft

deno: 1.0.0 -> 1.0.5 #88681

wants to merge 1 commit into from

Conversation

@06kellyjac
Copy link
Contributor

06kellyjac commented May 23, 2020

Motivation for this change

deno 1.0.5 released

Things done

Bumped version, sha, and cargo sha

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@marsam
Copy link
Contributor

marsam commented May 24, 2020

@GrahamcOfBorg build deno

@06kellyjac
Copy link
Contributor Author

06kellyjac commented May 24, 2020

Hmmm there seems to be a range of different tests failing for the different build targets.

I'll do some digging tomorrow

@06kellyjac 06kellyjac marked this pull request as draft May 26, 2020
@06kellyjac 06kellyjac force-pushed the 06kellyjac:deno_1.0.2 branch 3 times, most recently from 1f6e30e to 1b34a8c May 26, 2020
@06kellyjac
Copy link
Contributor Author

06kellyjac commented May 28, 2020

@marsam I'm really not too sure why the tests fail this way.
They're meant to be running an integration test (for the most commonly failing test type) e.g. "deno_test_fail_fast" which correctly compares it's output to "deno_test_fail_fast.out" but the output is from "deno_test" so it fails
I've had cases where I run the exact same nix & the tests build and pass the 2nd time so (IMO) it's highly likely there's something wrong with the deno tests & because of this temperamental nature of the issue it's a nightmare to reproduce.

This is the block of code responsible for the most failures:
https://github.com/denoland/deno/blob/master/cli/tests/integration_tests.rs#L2837-L2906

In one of my PRs I'm adding some logging for args and test_dir to help with the debugging:
https://github.com/denoland/deno/blob/master/cli/tests/integration_tests.rs#L2854-L2855
But if it's some kind of weird parallel stdout thingie where stdout from one test endup in another it wont help much.
Also it's supprising this kind of collision style issue doesn't show up more regularly in their CI. Maybe the CI is just running less parallel threads???


I like the tests running because it's fun & helps check for f-ups etc but should we turn the checks off for now until we get a handle on this?
Would love to hear your thoughts

@06kellyjac 06kellyjac force-pushed the 06kellyjac:deno_1.0.2 branch from 1b34a8c to f1490a9 Jun 2, 2020
@06kellyjac 06kellyjac changed the title deno: 1.0.0 -> 1.0.2 deno: 1.0.0 -> 1.0.3 Jun 2, 2020
@06kellyjac 06kellyjac force-pushed the 06kellyjac:deno_1.0.2 branch 2 times, most recently from 8ccf694 to f3c44a7 Jun 3, 2020
@06kellyjac 06kellyjac changed the title deno: 1.0.0 -> 1.0.3 deno: 1.0.0 -> 1.0.5 Jun 3, 2020
@06kellyjac 06kellyjac force-pushed the 06kellyjac:deno_1.0.2 branch from f3c44a7 to c2cd9fe Jun 4, 2020
@06kellyjac 06kellyjac force-pushed the 06kellyjac:deno_1.0.2 branch from c2cd9fe to 7c06663 Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.