Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lieer: 1.1 -> 1.2 #88683

Merged
merged 2 commits into from May 24, 2020
Merged

lieer: 1.1 -> 1.2 #88683

merged 2 commits into from May 24, 2020

Conversation

@flokli
Copy link
Contributor

flokli commented May 23, 2020

Motivation for this change

gmi send supporting -t, thus being compatible with neomutt (gauteh/lieer#154)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@flokli flokli force-pushed the flokli:lieer-1.2 branch from d7e92fe to eaea983 May 24, 2020
@flokli
Copy link
Contributor Author

flokli commented May 24, 2020

Updated to fetch the sources from PyPI, as they're published now too (gauteh/lieer#138 (comment)).

@kirelagin, can you take a look?

@kirelagin
Copy link
Member

kirelagin commented May 24, 2020

I once tried to add a new Python package, and someone suggested that I use GitLab instead of PyPi. I’m not sure what the policy in nixpkgs currently is, but the argument that the source repository is usually more up-to-date than PyPi sounds justified...

@flokli
Copy link
Contributor Author

flokli commented May 24, 2020

We prefer to fetch from git when tests are missing from the PyPI releases, but usually, PyPI is the more canonical location.

As lieer doesn't have tests, we don't need to worry about missing tests 🙈

gauteh/lieer#138 reads like PyPI should soon be always up to date on releases, but I'll ask back.

@flokli
Copy link
Contributor Author

flokli commented May 24, 2020

Let's merge this in fetching from PyPI for now, we can always flip it back to GitHub, if it turns out to be better there ;-)

@flokli flokli merged commit 34b3933 into NixOS:master May 24, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaea983"; rev="eaea983e41fb9d8cc19c4de6a95d1f32ec3b3612"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaea983"; rev="eaea983e41fb9d8cc19c4de6a95d1f32ec3b3612"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaea983"; rev="eaea983e41fb9d8cc19c4de6a95d1f32ec3b3612"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaea983"; rev="eaea983e41fb9d8cc19c4de6a95d1f32ec3b3612"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaea983"; rev="eaea983e41fb9d8cc19c4de6a95d1f32ec3b3612"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaea983"; rev="eaea983e41fb9d8cc19c4de6a95d1f32ec3b3612"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eaea983"; rev="eaea983e41fb9d8cc19c4de6a95d1f32ec3b3612"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
lieer, lieer.passthru.tests on aarch64-linux Success
Details
lieer, lieer.passthru.tests on x86_64-darwin Success
Details
lieer, lieer.passthru.tests on x86_64-linux Success
Details
@flokli flokli deleted the flokli:lieer-1.2 branch May 24, 2020
@flokli
Copy link
Contributor Author

flokli commented May 24, 2020

moved back to fetchFromGitHub in 2226972.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.