Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse: 0.7.0 -> 0.11.0 #88686

Open
wants to merge 2 commits into
base: master
from
Open

reuse: 0.7.0 -> 0.11.0 #88686

wants to merge 2 commits into from

Conversation

@ethulhu
Copy link

ethulhu commented May 23, 2020

Motivation for this change

reuse updated to 0.10.1.

Things done
  • Bumped version.

  • Updated SHA256.

  • Added new dependency, setuputils_scm.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

Ethel Morgan
Copy link
Contributor

FlorianFranzen left a comment

Looks good. Builds and runs well. Thank you for your contribution. LGTM!

Copy link
Member

geistesk left a comment

Perhaps you should update this PR to the latest upstream version. Otherwise, lgtm.

@@ -21,6 +21,7 @@ buildPythonApplication rec {
license-expression
requests
setuptools
setuptools_scm

This comment has been minimized.

Copy link
@geistesk

geistesk May 26, 2020

Member

Perhaps all the Python libraries should be included on their own and not the whole python3Packages in the first line. This was already the case before, but could perhaps be changed.

This comment has been minimized.

Copy link
@ethulhu

ethulhu May 29, 2020

Author

This PR is just the version bump; I would prefer to keep it single-purpose.

This comment has been minimized.

Copy link
@geistesk

geistesk Jun 2, 2020

Member

Okay, but perhaps someone should have another look at this later.

pkgs/tools/package-management/reuse/default.nix Outdated Show resolved Hide resolved
Ethel Morgan
@ethulhu ethulhu changed the title reuse: 0.7.0 -> 0.10.1 reuse: 0.7.0 -> 0.11.0 May 29, 2020
@ofborg ofborg bot requested a review from FlorianFranzen May 29, 2020
@geistesk geistesk self-requested a review Jun 2, 2020
Copy link
Member

geistesk left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.