Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyspice #88688

Open
wants to merge 3 commits into
base: master
from
Open

Pyspice #88688

wants to merge 3 commits into from

Conversation

@matthuszagh
Copy link
Contributor

matthuszagh commented May 23, 2020

Motivation for this change

Adds PySpice. I tested this on some of the examples in the doc and everything worked.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@matthuszagh matthuszagh requested review from FRidh and jonringer as code owners May 23, 2020
@ofborg ofborg bot added the 6.topic: python label May 23, 2020
@FRidh FRidh self-assigned this May 23, 2020
@FRidh
Copy link
Member

FRidh commented May 23, 2020

pyyaml and requests bumps need to be tested with a hydra job, so this PR is going to take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.