Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnuradio: format arguments and inputs #88693

Merged
merged 1 commit into from May 23, 2020
Merged

Conversation

@doronbehar
Copy link
Contributor

doronbehar commented May 23, 2020

Motivation for this change

This PR is a trial at splitting #84401 (comment) into easier to review pieces. The changes here have no effect on the result of the gnuradio. As you can check for yourself with the following commands (assuming you have hub installed).

nix show-derivation -f. gnuradio > /tmp/oldgnuradio.json
hub pr checkout 88693
nix show-derivation -f. gnuradio > /tmp/newgnuradio.json
diff /tmp/*gnuradio.json

Hence, I'm marking all of the items following as done because this isn't a real change.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar
Copy link
Contributor Author

doronbehar commented May 23, 2020

cc @flokli .

@flokli
Copy link
Contributor

flokli commented May 23, 2020

LGTM. Can the individual groups be sorted alphabetically? Or do you want to do that in a followup PR that will do a rebuild?

@doronbehar
Copy link
Contributor Author

doronbehar commented May 23, 2020

Can the individual groups be sorted alphabetically? Or do you want to do that in a followup PR that will do a rebuild?

No need for that, as many of the deps will be replaced and/or cleaned in a future PR and there they'll be grouped by a the purpose with even better comments then there are now.

@flokli
Copy link
Contributor

flokli commented May 23, 2020

Can the individual groups be sorted alphabetically? Or do you want to do that in a followup PR that will do a rebuild?

No need for that, as many of the deps will be replaced and/or cleaned in a future PR and there they'll be grouped by a the purpose with even better comments then there are now.

Fair enough :-)

@flokli flokli merged commit b0b3c30 into NixOS:master May 23, 2020
16 checks passed
16 checks passed
gnuradio, gnuradio.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
gnuradio, gnuradio.passthru.tests on aarch64-linux Success
Details
gnuradio, gnuradio.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="208b5fb"; rev="208b5fbd75800c2babc78f0439c55cd35c9a8196"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="208b5fb"; rev="208b5fbd75800c2babc78f0439c55cd35c9a8196"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="208b5fb"; rev="208b5fbd75800c2babc78f0439c55cd35c9a8196"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="208b5fb"; rev="208b5fbd75800c2babc78f0439c55cd35c9a8196"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="208b5fb"; rev="208b5fbd75800c2babc78f0439c55cd35c9a8196"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="208b5fb"; rev="208b5fbd75800c2babc78f0439c55cd35c9a8196"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="208b5fb"; rev="208b5fbd75800c2babc78f0439c55cd35c9a8196"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@doronbehar
Copy link
Contributor Author

doronbehar commented May 23, 2020

Thanks :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.