Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnch: init at 2017-02-16 #88694

Merged
merged 1 commit into from May 23, 2020
Merged

lnch: init at 2017-02-16 #88694

merged 1 commit into from May 23, 2020

Conversation

@AndersonTorres
Copy link
Member

AndersonTorres commented May 23, 2020

Motivation for this change

lnch is a small go app that launches a process and moves it out of the process
group. It is useful to some scripts that need to launch a process without
killing the previous one, like custom script app launchers for lightweight
window managers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
lnch is a small go app that launches a process and moves it out of the process
group. It is useful to some scripts that need to launch a process without
killing the previous one, like custom script app launchers for lightweight
window managers.
@AndersonTorres AndersonTorres merged commit 29d57de into NixOS:master May 23, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6cbffb9"; rev="6cbffb93ef91a870ed64ddb292b99051bf39312d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6cbffb9"; rev="6cbffb93ef91a870ed64ddb292b99051bf39312d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6cbffb9"; rev="6cbffb93ef91a870ed64ddb292b99051bf39312d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6cbffb9"; rev="6cbffb93ef91a870ed64ddb292b99051bf39312d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6cbffb9"; rev="6cbffb93ef91a870ed64ddb292b99051bf39312d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6cbffb9"; rev="6cbffb93ef91a870ed64ddb292b99051bf39312d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6cbffb9"; rev="6cbffb93ef91a870ed64ddb292b99051bf39312d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
lnch, lnch.passthru.tests on aarch64-linux Success
Details
lnch, lnch.passthru.tests on x86_64-linux Success
Details
};

meta = with stdenv.lib; {
homepage = "https://github.com/mitchellh/gox";

This comment has been minimized.

Copy link
@cole-h

cole-h May 23, 2020

Member

Wrong homepage?

This comment has been minimized.

Copy link
@AndersonTorres

AndersonTorres May 23, 2020

Author Member

Yes, I will fix it :/

homepage = "https://github.com/mitchellh/gox";
description = "A small go app that launches a process and moves it out of the process group";
platforms = platforms.all;
license = licenses.publicDomain; # really I don't know

This comment has been minimized.

Copy link
@cole-h

cole-h May 23, 2020

Member

I don't think the absence of a license places it in the public domain.

This comment has been minimized.

Copy link
@AndersonTorres

AndersonTorres May 23, 2020

Author Member

I will try to contact the upstream

@orivej
Copy link
Contributor

orivej commented May 23, 2020

I do not quiet understand your use case but it seems that the standard setsid utility would fulfill it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.