Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transmission: 2.94 -> 3.00 #88701

Merged
merged 1 commit into from May 24, 2020
Merged

transmission: 2.94 -> 3.00 #88701

merged 1 commit into from May 24, 2020

Conversation

@adisbladis
Copy link
Member

adisbladis commented May 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@adisbladis adisbladis force-pushed the adisbladis:transmission-3_00 branch from 9888108 to c1a150f May 23, 2020
@ofborg ofborg bot requested review from astsmtl, wizeman and vcunat May 23, 2020
@adisbladis adisbladis force-pushed the adisbladis:transmission-3_00 branch from c1a150f to 83018f4 May 23, 2020
Copy link
Contributor

tomberek left a comment

Builds, runs, and functions as expected on NixOS. Did not test OSX.

@vcunat
vcunat approved these changes May 24, 2020
Copy link
Member

vcunat left a comment

I see no issues so far.

@adisbladis adisbladis merged commit 37cdb3c into NixOS:master May 24, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="83018f4"; rev="83018f4fc6c47419c5fb0e12852fe3ff4759449a"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="83018f4"; rev="83018f4fc6c47419c5fb0e12852fe3ff4759449a"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="83018f4"; rev="83018f4fc6c47419c5fb0e12852fe3ff4759449a"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="83018f4"; rev="83018f4fc6c47419c5fb0e12852fe3ff4759449a"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="83018f4"; rev="83018f4fc6c47419c5fb0e12852fe3ff4759449a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="83018f4"; rev="83018f4fc6c47419c5fb0e12852fe3ff4759449a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="83018f4"; rev="83018f4fc6c47419c5fb0e12852fe3ff4759449a"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
transmission, transmission.passthru.tests on aarch64-linux Success
Details
transmission, transmission.passthru.tests on x86_64-darwin Success
Details
transmission, transmission.passthru.tests on x86_64-linux Success
Details
@diamondburned
Copy link

diamondburned commented Jun 1, 2020

This commit made Transmission fail to detect all of my old torrents. I will try and roll it back with some override jankery.

Edit: They didn't come back.

@vcunat
Copy link
Member

vcunat commented Jun 1, 2020

Hmm, the new version does migrate the *.torrent files to a new naming scheme, but that worked for me without a problem. Perhaps it would be best to discuss your case with upstream.

@anna328p
Copy link
Member

anna328p commented Jun 6, 2020

This deleted all of my torrent files!!

@vcunat
Copy link
Member

vcunat commented Jun 24, 2020

Could you two be running into this issue? transmission/transmission#1325

In any case those problems will probably be best taken upstream (like that link above). I hope they will be rare enough.

@anna328p
Copy link
Member

anna328p commented Jun 25, 2020

Could you two be running into this issue? transmission/transmission#1325

In any case those problems will probably be best taken upstream (like that link above). I hope they will be rare enough.

No. The torrent files were just deleted; the directory was completely empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.