Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: fix zha in home-assistant #88715

Closed
wants to merge 9 commits into from
Closed

Conversation

@etu
Copy link
Contributor

etu commented May 23, 2020

Motivation for this change

ZHA broke a while ago and I haven't got around to fix it...

But now I've started to sort out some of the mess in the python packaging related to zha and zigpy.

Now it installs fine and loads zha, kinda. But it doesn't manage to actually set it up for me with the following error:
image

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
etu added 9 commits Mar 24, 2020
…nother pypi package
@etu etu requested review from FRidh and jonringer as code owners May 23, 2020
@@ -932,7 +932,7 @@
"zeroconf" = ps: with ps; [ aiohttp-cors zeroconf];
"zerproc" = ps: with ps; [ ]; # missing inputs: pyzerproc
"zestimate" = ps: with ps; [ xmltodict];
"zha" = ps: with ps; [ pyserial zha-quirks zigpy-deconz]; # missing inputs: bellows zigpy-cc zigpy-xbee zigpy-zigate zigpy
"zha" = ps: with ps; [ bellows pyserial zha-quirks zigpy zigpy-cc zigpy-deconz zigpy-xbee zigpy-zigate];

This comment has been minimized.

Copy link
@etu

etu May 23, 2020

Author Contributor

Note of interest which I don't know what to do about:

When I ran the generator to update this file it did put the zigpy dependency at the end of the list. Then home-assistant failed to load zigpy.config because something seemed to depend on it before it was loaded. This may be an upstream issue in how the requirements list is parsed, otherwise it's a sorting issue in our updater file.

cc @FRidh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.