Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services.x11.videoDrivers: Don't include vmware driver on non-x86 platforms #88718

Merged
merged 1 commit into from Jun 11, 2020

Conversation

@adisbladis
Copy link
Member

adisbladis commented May 23, 2020

Motivation for this change

This driver is x86 only.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@adisbladis adisbladis force-pushed the adisbladis:vmware-xorg-driver-defaults branch 2 times, most recently from 4f6f797 to d963996 May 24, 2020
@adisbladis
Copy link
Member Author

adisbladis commented May 24, 2020

I've opted to simply remove vmware from the default drivers, there is a vmware guest module that sets this driver and it doesn't make sense to have it in the defaults list.

Copy link
Contributor

flokli left a comment

Please add an entry to the release notes mentioning this and directing people to set options.virtualisation.vmware.guest.enable = true, so we don't drop this silently.

@adisbladis adisbladis force-pushed the adisbladis:vmware-xorg-driver-defaults branch 2 times, most recently from 49cffe3 to 3f97a5b Jun 11, 2020
A better option for vmware guests is to set `virtualisation.vmware.guest.enable`.
@adisbladis adisbladis force-pushed the adisbladis:vmware-xorg-driver-defaults branch from 3f97a5b to 1a5dafc Jun 11, 2020
@adisbladis adisbladis merged commit a5a52e8 into NixOS:master Jun 11, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a5dafc"; rev="1a5dafcd5bebd2ad915876333b0ba94680148db7"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a5dafc"; rev="1a5dafcd5bebd2ad915876333b0ba94680148db7"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a5dafc"; rev="1a5dafcd5bebd2ad915876333b0ba94680148db7"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a5dafc"; rev="1a5dafcd5bebd2ad915876333b0ba94680148db7"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a5dafc"; rev="1a5dafcd5bebd2ad915876333b0ba94680148db7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a5dafc"; rev="1a5dafcd5bebd2ad915876333b0ba94680148db7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1a5dafc"; rev="1a5dafcd5bebd2ad915876333b0ba94680148db7"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.