Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.nextcloud: Add davfs2 example to the VM test #88721

Merged
merged 1 commit into from May 23, 2020

Conversation

@flokli
Copy link
Contributor

flokli commented May 23, 2020

Some people use davfs2 to mount a NextCloud instance, so make sure this
works as well.

The /tmp/davfs2-secrets file needs to be created via an activation script, as mount.davfs2 doesn't like it to that file world-readable (which it is if it comes from the nix store).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Ma27
Ma27 approved these changes May 23, 2020
nixos/tests/nextcloud/basic.nix Outdated Show resolved Hide resolved
@flokli flokli force-pushed the flokli:nixostests-nextcloud-davfs2 branch from ae5ed5a to 0aac5e7 May 23, 2020
Some people use davfs2 to mount a NextCloud instance, so make sure this
works as well.
@flokli flokli force-pushed the flokli:nixostests-nextcloud-davfs2 branch from 0aac5e7 to 75e18ab May 23, 2020
@flokli
Copy link
Contributor Author

flokli commented May 23, 2020

In fact, we can also skip the _netdev option, as systemd-fstab-generator knows davfs mounts are networked. Sweet :-)

@Ma27 Ma27 merged commit 946f7d1 into NixOS:master May 23, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e18ab"; rev="75e18ab32379377d445ebee04d355125627e3d19"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e18ab"; rev="75e18ab32379377d445ebee04d355125627e3d19"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e18ab"; rev="75e18ab32379377d445ebee04d355125627e3d19"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e18ab"; rev="75e18ab32379377d445ebee04d355125627e3d19"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e18ab"; rev="75e18ab32379377d445ebee04d355125627e3d19"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e18ab"; rev="75e18ab32379377d445ebee04d355125627e3d19"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75e18ab"; rev="75e18ab32379377d445ebee04d355125627e3d19"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@flokli flokli deleted the flokli:nixostests-nextcloud-davfs2 branch May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.