Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: fix cmake include path #88723

wants to merge 1 commit into from


Copy link

sheenobu commented May 23, 2020

Motivation for this change

fmt has a bad cmake path for include because of the two derivations. This was included as part of this PR: #63097

fixes #86622 and #87473 and unblocks #84117

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
change the include path in fmt cmake in order to point to the dev
derivation instead of the out derivation.
@sheenobu sheenobu force-pushed the sheenobu:bugfix/86622/fmt-substitute branch from 651f429 to 00dff9a May 23, 2020
@ofborg ofborg bot requested a review from jeroendehaas May 23, 2020
Copy link

orivej commented May 27, 2020

I'm upstreaming a fix for this issue at fmtlib/fmt#1702 . If it is merged soon enough I'll fetchpatch it into fmt.

@orivej orivej mentioned this pull request May 28, 2020
5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.