Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/chromium: add example and update description #88744

merged 1 commit into from Jun 1, 2020


Copy link

@davidak davidak commented May 24, 2020

Motivation for this change


Screenshot from 2020-05-24 06 13 20

Things done
  • Tested example on stable channel
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • [] macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
NickHu approved these changes May 24, 2020
@davidak davidak force-pushed the chromium-example branch from 95e972e to 297c265 May 24, 2020
@davidak davidak changed the title nixos/chromium: add example and update URL nixos/chromium: add example and update description May 24, 2020
@Lassulus Lassulus merged commit 29062ce into NixOS:master Jun 1, 2020
14 checks passed
@davidak davidak deleted the chromium-example branch Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants