Add IntelliJ IDEA CE version 11. #89

Closed
wants to merge 13 commits into
from

Conversation

Projects
None yet
4 participants
@coreyoconnor
Contributor

coreyoconnor commented Aug 7, 2012

The source distribution static binaries of fsnotifier and fsnotifier64 are patched.
This can be improved: I'm not sure of the best way to fetch patch both the 32bit and 64bit versions. Only the one that is assumed to be picked by the idea.sh is patched.

coreyoconnor added some commits Aug 5, 2012

Add IntelliJ IDEA CE version 11.
The source distribution static binaries of fsnotifier and fsnotifier64 are patched.
I'm not sure of the best way to fetch patch both the 32bit and 64bit versions. Only the one that is
assumed to be picked by the idea.sh is patched.
Up version of Dev86 to 0.16.19.
0.16.18 was removed from the server.
@aszlig

This comment has been minimized.

Show comment Hide comment
@aszlig

aszlig Sep 11, 2012

What's the reason for the custom builder here?

What's the reason for the custom builder here?

@aszlig

This comment has been minimized.

Show comment Hide comment
@aszlig

aszlig Sep 11, 2012

You could do this as well in a postUnpack hook.

You could do this as well in a postUnpack hook.

+
+tar --strip-components=1 -zxvf out/artifacts/ideaIC-111.SNAPSHOT.tar.gz -C $out
+
+patchelf --set-interpreter "$(cat $NIX_GCC/nix-support/dynamic-linker)" $out/bin/${notifierToPatch}

This comment has been minimized.

Show comment Hide comment
@aszlig

aszlig Sep 11, 2012

Member

You could omit the notifierToPatch attribute and use "$out"/bin/fsnotifier* instead.

@aszlig

aszlig Sep 11, 2012

Member

You could omit the notifierToPatch attribute and use "$out"/bin/fsnotifier* instead.

+ desktopName = "IntelliJ IDEA CE";
+ genericName = "IntelliJ IDEA Community Edition";
+ categories = "Application;Development;";
+ };

This comment has been minimized.

Show comment Hide comment
@aszlig

aszlig Sep 11, 2012

Member

Please indent using two spaces and don't try to align function calls within the call, as this wrapps your code way too far to the right.
http://hydra.nixos.org/build/3009964/download/2/manual/#chap-conventions

An example for this case:

  desktopItem = makeDesktopItem {   
    name = "IntelliJ-IDEA-CE";
    exec = "idea.sh";
    icon = "idea_CE128.png";
    comment = "IntelliJ IDEA Community Edition";
    desktopName = "IntelliJ IDEA CE";
    genericName = "IntelliJ IDEA Community Edition";
    categories = "Application;Development;";
  };
@aszlig

aszlig Sep 11, 2012

Member

Please indent using two spaces and don't try to align function calls within the call, as this wrapps your code way too far to the right.
http://hydra.nixos.org/build/3009964/download/2/manual/#chap-conventions

An example for this case:

  desktopItem = makeDesktopItem {   
    name = "IntelliJ-IDEA-CE";
    exec = "idea.sh";
    icon = "idea_CE128.png";
    comment = "IntelliJ IDEA Community Edition";
    desktopName = "IntelliJ IDEA CE";
    genericName = "IntelliJ IDEA Community Edition";
    categories = "Application;Development;";
  };
@coreyoconnor

This comment has been minimized.

Show comment Hide comment
@coreyoconnor

coreyoconnor Sep 11, 2012

Owner

Thanks for the feedback. I'll make the appropriate updates.

Owner

coreyoconnor commented on f8a2ac5 Sep 11, 2012

Thanks for the feedback. I'll make the appropriate updates.

vcunat added a commit that referenced this pull request Feb 10, 2013

freetype+fontconfig: add infinality and enable it
Also add fontconfig checks
, change license to "unfree" if using patented code.

Inspired by Corey O'Connor in #89
coreyoconnor@27fec0a
@vcunat

This comment has been minimized.

Show comment Hide comment
@vcunat

vcunat Feb 10, 2013

Member

I pushed infinality into x-updates, as fontconfig affects very many packages.

Member

vcunat commented Feb 10, 2013

I pushed infinality into x-updates, as fontconfig affects very many packages.

vcunat added a commit that referenced this pull request Feb 10, 2013

coreyoconnor added some commits Feb 14, 2013

Merge branch 'upstream'
Conflicts:
	pkgs/misc/emulators/wine/build_winetricks.sh
	pkgs/misc/emulators/wine/winetricks.nix
	pkgs/top-level/all-packages.nix
@coreyoconnor

This comment has been minimized.

Show comment Hide comment
@coreyoconnor

coreyoconnor Feb 17, 2013

Contributor

Thanks for finishing the infinality patch!
What should I do with this pull request? Seems like I should cancel this one, fix up the IntelliJ patches, then open a new one. Or should I jsut keep this open until I get around to fixing the intellij patches? Not sure of the correct github etiquette for this.

Contributor

coreyoconnor commented Feb 17, 2013

Thanks for finishing the infinality patch!
What should I do with this pull request? Seems like I should cancel this one, fix up the IntelliJ patches, then open a new one. Or should I jsut keep this open until I get around to fixing the intellij patches? Not sure of the correct github etiquette for this.

@vcunat

This comment has been minimized.

Show comment Hide comment
@vcunat

vcunat Feb 17, 2013

Member

I would keep this request. I takes commits by the branch name, so you can change it completely.

BTW, I tried to fix the problems in the expression and also update it to 12.0.3 https://github.com/vcunat/nixpkgs/compare/vlada;idea Feel free to build on it. It compiles fine, but on running I get the exceptions below. I haven't looked into it since.

$ ./result/bin/idea.sh Java HotSpot(TM) 64-Bit Server VM (build 20.7-b02, mixed mode) Exception in thread "main" java.lang.NoClassDefFoundError: java/lang/ReflectiveOperationException at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:247) at com.intellij.ide.Bootstrap.main(Bootstrap.java:40) at com.intellij.ide.Bootstrap.main(Bootstrap.java:34) at com.intellij.idea.Main.main(Main.java:81) Caused by: java.lang.ClassNotFoundException: java.lang.ReflectiveOperationException at com.intellij.util.lang.UrlClassLoader.findClass(UrlClassLoader.java:79) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at com.intellij.util.lang.UrlClassLoader.loadClass(UrlClassLoader.java:92) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) ... 5 more
Member

vcunat commented Feb 17, 2013

I would keep this request. I takes commits by the branch name, so you can change it completely.

BTW, I tried to fix the problems in the expression and also update it to 12.0.3 https://github.com/vcunat/nixpkgs/compare/vlada;idea Feel free to build on it. It compiles fine, but on running I get the exceptions below. I haven't looked into it since.

$ ./result/bin/idea.sh Java HotSpot(TM) 64-Bit Server VM (build 20.7-b02, mixed mode) Exception in thread "main" java.lang.NoClassDefFoundError: java/lang/ReflectiveOperationException at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:247) at com.intellij.ide.Bootstrap.main(Bootstrap.java:40) at com.intellij.ide.Bootstrap.main(Bootstrap.java:34) at com.intellij.idea.Main.main(Main.java:81) Caused by: java.lang.ClassNotFoundException: java.lang.ReflectiveOperationException at com.intellij.util.lang.UrlClassLoader.findClass(UrlClassLoader.java:79) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at com.intellij.util.lang.UrlClassLoader.loadClass(UrlClassLoader.java:92) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) ... 5 more
@shlevy

This comment has been minimized.

Show comment Hide comment
@shlevy

shlevy Feb 22, 2013

Member

@coreyoconnor Do you want this still to be open?

Member

shlevy commented Feb 22, 2013

@coreyoconnor Do you want this still to be open?

@shlevy

This comment has been minimized.

Show comment Hide comment
@shlevy

shlevy Mar 8, 2013

Member

Closing this for now, feel free to reopen if this is still valid.

Member

shlevy commented Mar 8, 2013

Closing this for now, feel free to reopen if this is still valid.

@shlevy shlevy closed this Mar 8, 2013

vandenoever pushed a commit to vandenoever/nixpkgs that referenced this pull request Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment