Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cde-gtk-theme: init at 1.3 #89163

Merged
merged 1 commit into from Jun 1, 2020
Merged

cde-gtk-theme: init at 1.3 #89163

merged 1 commit into from Jun 1, 2020

Conversation

@gnidorah
Copy link
Member

gnidorah commented May 29, 2020

Motivation for this change

Gtk2 / Gtk3 theme mimicking CDE / Motif

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sauyon
Copy link
Member

sauyon commented May 29, 2020

I'm getting a 410 gone from the URL:

trying https://dllb2.pling.com/api/files/download/j/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpZCI6IjE1MjU3Mzc1MTAiLCJ1IjpudWxsLCJsdCI6ImRvd25sb2FkIiwicyI6ImI2NTBiZjk0NDEzYjRjYmRmNzgxMWZhNmIyZjAzMzYwNmUzNDIxNzYxYmY0MDMzYTgxYjk0ZDUwZTdkMDlkOWIxYTQ5MzYzODk4NTA0YThmODQxYWMxYTZlMzMwZDY1MmRhMzI3ZDc1ZDRkYTIzMzAwZWI5ZWU3MGJiOTBjNGI2IiwidCI6MTU5MDc1MjU2MSwic3RmcCI6ImJjYTRlNTQ4NDlhMmJkM2I2MGY5MGY0NmU4OTc1MjEzIiwic3RpcCI6IjE3Ni4xOTMuMTQuMTA2In0.1-A_r3bCm-5pJQKviPcWKfrsdm8Xp6AyHiU0d7LJj3w/cdetheme1.3.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 410 Gone
error: cannot download cdetheme1.3.tar.gz from any mirror

Seems like this is a temporary URL?

@gnidorah gnidorah force-pushed the gnidorah:cdetheme branch from edfd880 to 8791713 May 30, 2020
@gnidorah gnidorah marked this pull request as draft May 30, 2020
@gnidorah gnidorah force-pushed the gnidorah:cdetheme branch from 8791713 to 3b6c350 May 30, 2020
@gnidorah gnidorah marked this pull request as ready for review May 30, 2020
@gnidorah
Copy link
Member Author

gnidorah commented May 30, 2020

@sauyon Fixed, thanks

@sauyon
Copy link
Member

sauyon commented May 31, 2020

The details section of the theme description seem to suggest that it's licensed under GPLv3, but that's not found in the repo you added as a source. Are you the author of the theme? It looks like you own the opencode repo, at least.

Otherwise, this LGTM.

I'll test this on Arch in a bit.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@gnidorah gnidorah force-pushed the gnidorah:cdetheme branch from 3b6c350 to 6249944 May 31, 2020
@gnidorah gnidorah changed the title cdetheme: init at 1.3 cde-gtk-theme: init at 1.3 May 31, 2020
@gnidorah
Copy link
Member Author

gnidorah commented May 31, 2020

@sauyon No, I'm not the author, just uploaded it to opencode. I've contacted the author with kind ask to upload it by himself and add license.

@gnidorah gnidorah force-pushed the gnidorah:cdetheme branch from 6249944 to 8ff519a Jun 1, 2020
@gnidorah
Copy link
Member Author

gnidorah commented Jun 1, 2020

@sauyon Theme author uploaded it to github and added license 👍 I've updated the package accordingly.

@gnidorah gnidorah requested a review from sauyon Jun 1, 2020
@gnidorah gnidorah force-pushed the gnidorah:cdetheme branch from 8ff519a to 7e910a6 Jun 1, 2020
Copy link
Contributor

romildo left a comment

It fits better at the ### DATA section instead of the current ### BUILD SUPPORT section of all-packages.nix.

@gnidorah gnidorah force-pushed the gnidorah:cdetheme branch from 7e910a6 to 0add877 Jun 1, 2020
@gnidorah gnidorah requested a review from romildo Jun 1, 2020
@gnidorah
Copy link
Member Author

gnidorah commented Jun 1, 2020

@romildo Fixed, thank you!

@romildo
romildo approved these changes Jun 1, 2020
@gnidorah gnidorah force-pushed the gnidorah:cdetheme branch from 0add877 to 51a2442 Jun 1, 2020
@sauyon
sauyon approved these changes Jun 1, 2020
Copy link
Member

sauyon left a comment

LGTM

@NickHu
NickHu approved these changes Jun 1, 2020
@NickHu
Copy link
Contributor

NickHu commented Jun 1, 2020

Tested in lxappearance on nixos.

Thanks for your contribution!

Result of nixpkgs-review pr 89163 1

1 package built:
- cde-gtk-theme
@NickHu NickHu merged commit 052fa90 into NixOS:master Jun 1, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
cde-gtk-theme, cde-gtk-theme.passthru.tests on aarch64-linux Success
Details
cde-gtk-theme, cde-gtk-theme.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51a2442"; rev="51a244259cce1c944ac8af50f213da087499e689"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51a2442"; rev="51a244259cce1c944ac8af50f213da087499e689"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51a2442"; rev="51a244259cce1c944ac8af50f213da087499e689"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51a2442"; rev="51a244259cce1c944ac8af50f213da087499e689"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51a2442"; rev="51a244259cce1c944ac8af50f213da087499e689"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51a2442"; rev="51a244259cce1c944ac8af50f213da087499e689"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="51a2442"; rev="51a244259cce1c944ac8af50f213da087499e689"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@gnidorah
Copy link
Member Author

gnidorah commented Jun 1, 2020

@gnidorah gnidorah deleted the gnidorah:cdetheme branch Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.