Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-jira: 1.0.17 -> 1.0.23 #89183

merged 2 commits into from Jun 1, 2020

go-jira: 1.0.17 -> 1.0.23 #89183

merged 2 commits into from Jun 1, 2020


Copy link

@timstott timstott commented May 29, 2020

Motivation for this change

Update to version 1.0.23

Go Jira Changelog 1.0.17 -> 1.0.23

1.0.22 - 2019-09-30

  • fix syntax [Cory Bennett] [807ca76]
  • Address comments for direct name match [Patrick Cockwell] [a70384b]
  • Choose exact transition match if available [Patrick Cockwell] [a646f76]

1.0.21 - 2019-09-16

  • [#277] update figtree to latest [Cory Bennett] [0e520a4]
  • Switch over to using, from [Mike Pountney] [27f57b2]
  • fix worklog template to allow multiline comments [Matthias Bethke] [43e07f1]
  • Allow reading password from stdin [Justin Ko] [225e1dc]
  • all: unindent some code [Daniel Martí] [31c113d]
  • don't use ReadAll when decoding JSON [Daniel Martí] [9bcdcc1]
  • start making staticcheck happier [Daniel Martí] [9b9186f]
  • all: convert to a Go module [Daniel Martí] [f125ef3]
  • CI: test on Go 1.12.x, cleanup [Daniel Martí] [664c5ca]
  • make automatic pagination on search optional, fix tests [Cory Bennett] [36c99ce]
  • prefer defer resp.Body.Close to avoid leaks on subsequent errors [Cory Bennett] [181bd74]
  • add pagination to search [Miles Maddox] [76dd1d8]
  • Fix function comments based on best practices from Effective Go [CodeLingo Bot] [23ac118]
  • [#201] update required library, failing to populate cookiejar from cookies file [Cory Bennett] [ee69afa]

1.0.20 - 2018-08-04

  • [#201] update required library, failing to populate cookiejar from cookies file [Cory Bennett] [ee69afa]

1.0.19 - 2018-08-02

  • [#199] [#198] update http client library, fix issues with internal login retries [Cory Bennett] [0cba806]

1.0.18 - 2018-07-29

  • [#196] add jira session command to show session information if user is authenticated [Cory Bennett] [f592107]
  • [#192] fix template usage for 'fixVersions' in transition template [Cory Bennett] [c9a4e30]
  • move HandleExit to the jiracli package [Cory Bennett] [ef9b731]
  • they broke ERROR: vendor/ use of internal package not allowed [Cory Bennett] [7191c77]
  • udpate deps [Cory Bennett] [d16bcc2]
  • udpate for figtree api changes [Cory Bennett] [07ba74b]
  • udpate to use latest dep, update figtree [Cory Bennett] [462ef1c]
  • [#171] change proposed PasswordPath to PasswordName [Cory Bennett] [213a7e0]
  • add pass path to config [dvogt23] [fa01ff5]

Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

    • before 44.4M
    • after 50.6M
  • Ensured that relevant documentation is up to date

  • Fits

Copy link

@carlosdagos carlosdagos commented May 30, 2020

The repo was renamed to go-jira/jira and the program to jira. Any thoughts about renaming the package name in all-packages.nix as well?

Copy link
Contributor Author

@timstott timstott commented May 30, 2020

Thank you for your review @carlosdagos. I would be weary of changing the package name to strictly jira to avoid any confusion with Atlassian's Jira. Also I would think the packages remains most commonly known as go-jira despite the new repository.

Let me know what your thoughts are 😃.

Copy link

@kalbasit kalbasit left a comment

please rebase your commits as mentioned in my comment. otherwise LGTM.

maintainers/maintainer-list.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from kalbasit May 31, 2020
Copy link
Contributor Author

@timstott timstott commented May 31, 2020

Thank you for your review @kalbasit, I have addressed both comments, the maintained addition has been extracted into it's own commit and the branch has been rebased on top of latest master.

Copy link

@kalbasit kalbasit commented May 31, 2020

@GrahamcOfBorg build go-jira

Copy link

@carlosdagos carlosdagos left a comment

I'm happy. Thanks @timstott 😄

@Ma27 Ma27 merged commit b447269 into NixOS:master Jun 1, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants