Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musescore: Add missing inputs qtgraphicaleffects, qtquickcontrols2 #89204

Merged
merged 1 commit into from Jun 23, 2020

Conversation

@andersk
Copy link
Contributor

andersk commented May 30, 2020

Motivation for this change

Although MuseScore builds and starts without these, it’s unusable because the left palette fails to render, with these errors:

qrc:/qml/palettes/PalettesWidget.qml:21:1: module "QtQuick.Controls" version 2.1 is not installed

or

qrc:/qml/palettes/PalettesWidget.qml:47:5: Type PalettesWidgetHeader unavailable
qrc:/qml/palettes/PalettesWidgetHeader.qml:37:5: Type StyledButton unavailable
qrc:/qml/palettes/StyledButton.qml:22:1: module "QtGraphicalEffects" is not installed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Although MuseScore builds and starts without these, it’s unusable
because the left palette fails to render, with these errors:

qrc:/qml/palettes/PalettesWidget.qml:21:1: module "QtQuick.Controls" version 2.1 is not installed

or

qrc:/qml/palettes/PalettesWidget.qml:47:5: Type PalettesWidgetHeader unavailable
qrc:/qml/palettes/PalettesWidgetHeader.qml:37:5: Type StyledButton unavailable
qrc:/qml/palettes/StyledButton.qml:22:1: module "QtGraphicalEffects" is not installed

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@vandenoever
Copy link
Contributor

vandenoever commented May 30, 2020

Looks good.

Copy link
Contributor

doronbehar left a comment

I can confirm the changes fix the errors at hand. Thank you! 🎷 .

@andersk andersk added the 0.kind: bug label Jun 18, 2020
@grahamc grahamc merged commit 00aebe9 into NixOS:master Jun 23, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ed1ae0"; rev="7ed1ae0d6b64e2599f3f9c24458aa5ec52f9bf6d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ed1ae0"; rev="7ed1ae0d6b64e2599f3f9c24458aa5ec52f9bf6d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ed1ae0"; rev="7ed1ae0d6b64e2599f3f9c24458aa5ec52f9bf6d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ed1ae0"; rev="7ed1ae0d6b64e2599f3f9c24458aa5ec52f9bf6d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ed1ae0"; rev="7ed1ae0d6b64e2599f3f9c24458aa5ec52f9bf6d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ed1ae0"; rev="7ed1ae0d6b64e2599f3f9c24458aa5ec52f9bf6d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7ed1ae0"; rev="7ed1ae0d6b64e2599f3f9c24458aa5ec52f9bf6d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
musescore, musescore.passthru.tests on aarch64-linux Success
Details
musescore, musescore.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.