Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcon: init at 0.5 #89227

Merged
merged 1 commit into from Oct 26, 2020
Merged

rcon: init at 0.5 #89227

merged 1 commit into from Oct 26, 2020

Conversation

@f4814
Copy link
Contributor

@f4814 f4814 commented May 30, 2020

Motivation for this change

There is no source RCON client in the repository.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@f4814
Copy link
Contributor Author

@f4814 f4814 commented Jul 14, 2020

Is there a reason not to merge this?

dali99
dali99 approved these changes Aug 23, 2020
@dali99
Copy link
Member

@dali99 dali99 commented Aug 31, 2020

rebase on master

I think it's okay to ping @jonringer about this PR as well to get it merged

pkgs/tools/networking/rcon/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@f4814
Copy link
Contributor Author

@f4814 f4814 commented Oct 1, 2020

@jonringer Anyting still preventing a merge here?

@ryantm
Copy link
Member

@ryantm ryantm commented Oct 26, 2020

Result of nixpkgs-review pr 89227 1

1 package built:
- rcon

ryantm
ryantm approved these changes Oct 26, 2020
@ryantm ryantm merged commit 9972560 into NixOS:master Oct 26, 2020
19 checks passed
@f4814 f4814 deleted the rcon-init branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants