Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuptime: 4.1.0 -> 5.0.0 #89235

Merged
merged 2 commits into from Jun 20, 2020
Merged

tuptime: 4.1.0 -> 5.0.0 #89235

merged 2 commits into from Jun 20, 2020

Conversation

@evils
Copy link
Contributor

evils commented May 31, 2020

Motivation for this change

a new major version was released

Notes

the database format has changed, though it seems it keeps working without manual intervention
it either converted the database by itself, or it can parse the old version as well
a script to update the database format is included, this adds the sqlite dependency

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • was 106428288, is 107888720 (increased due to adding sqlite to the database update script?)
  • Ensured that relevant documentation is up to date
    • this package/module isn't in 20.03 so no release note about the database change is required?
  • Fits CONTRIBUTING.md.
@evils
Copy link
Contributor Author

evils commented Jun 19, 2020

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 19, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 19, 2020
Copy link
Member

timokau left a comment

Some clarifications needed.

nixos/modules/services/monitoring/tuptime.nix Outdated Show resolved Hide resolved
pkgs/tools/system/tuptime/default.nix Outdated Show resolved Hide resolved
pkgs/tools/system/tuptime/default.nix Outdated Show resolved Hide resolved
@timokau
Copy link
Member

timokau commented Jun 19, 2020

/status needs_work

@evils evils force-pushed the evils:tuptime branch from e125cc1 to 8055123 Jun 19, 2020
@evils
Copy link
Contributor Author

evils commented Jun 19, 2020

/status needs_review

@ofborg ofborg bot added the 8.has: clean-up label Jun 19, 2020
evils added 2 commits May 31, 2020
uptimed import script removed from source ("unreliable")
new database format, including migration script instead
@evils evils force-pushed the evils:tuptime branch from 8055123 to 73a90b0 Jun 20, 2020
@Mic92 Mic92 merged commit 7c945cb into NixOS:master Jun 20, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73a90b0"; rev="73a90b015433e68a95a4ecdd14bfa3c175d7f7f6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73a90b0"; rev="73a90b015433e68a95a4ecdd14bfa3c175d7f7f6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73a90b0"; rev="73a90b015433e68a95a4ecdd14bfa3c175d7f7f6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73a90b0"; rev="73a90b015433e68a95a4ecdd14bfa3c175d7f7f6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73a90b0"; rev="73a90b015433e68a95a4ecdd14bfa3c175d7f7f6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73a90b0"; rev="73a90b015433e68a95a4ecdd14bfa3c175d7f7f6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="73a90b0"; rev="73a90b015433e68a95a4ecdd14bfa3c175d7f7f6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tuptime, tuptime.passthru.tests on aarch64-linux Success
Details
tuptime, tuptime.passthru.tests on x86_64-linux Success
Details
@timokau
Copy link
Member

timokau commented Jun 20, 2020

Thanks!

@marvin-mk2 marvin-mk2 bot requested a review from timokau Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.