Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated 'copy_file_from_host' from the manual #89238

Merged
merged 1 commit into from Jun 1, 2020

Conversation

@tomfitzhenry
Copy link
Contributor

tomfitzhenry commented May 31, 2020

https://nixos.org/nixos/manual/index.html#sec-nixos-tests mentions copy_file_from_host but this no longer exists, as of #72810 in which it was purposefully removed.

Let's remove this stale mention.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@tfc
Copy link
Contributor

tfc commented May 31, 2020

Hey @tomfitzhenry, thank you! This is good becasue the obsolete documentation was of course a bit misleading/confusing.

This is fine for merging but it might be more helpful for readers if the comment was refreshed to mention the correct existing function copy_from_host. Can i ask you to do that please?

@tomfitzhenry tomfitzhenry force-pushed the tomfitzhenry:patch-2 branch from a23dcad to d0c4b3d Jun 1, 2020
This was renamed in the Perl -> Python test driver migration.
@tomfitzhenry tomfitzhenry force-pushed the tomfitzhenry:patch-2 branch from d0c4b3d to f3c8acc Jun 1, 2020
@tomfitzhenry
Copy link
Contributor Author

tomfitzhenry commented Jun 1, 2020

Hey @tomfitzhenry, thank you! This is good becasue the obsolete documentation was of course a bit misleading/confusing.

Thanks for the review!

This is fine for merging but it might be more helpful for readers if the comment was refreshed to mention the correct existing function copy_from_host. Can i ask you to do that please?

Ah, I wasn't aware of copy_from_host. I've checked that function, and it behaves the same way as copy_file_from_host, so I've just updated the doc string to use the correct function name.

@tfc
Copy link
Contributor

tfc commented Jun 1, 2020

@tomfitzhenry thank you! 👍

@tfc tfc merged commit 2a9dadf into NixOS:master Jun 1, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3c8acc"; rev="f3c8acc0bba76d248ec335ed43f7ae4d366c62c2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3c8acc"; rev="f3c8acc0bba76d248ec335ed43f7ae4d366c62c2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3c8acc"; rev="f3c8acc0bba76d248ec335ed43f7ae4d366c62c2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3c8acc"; rev="f3c8acc0bba76d248ec335ed43f7ae4d366c62c2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3c8acc"; rev="f3c8acc0bba76d248ec335ed43f7ae4d366c62c2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3c8acc"; rev="f3c8acc0bba76d248ec335ed43f7ae4d366c62c2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3c8acc"; rev="f3c8acc0bba76d248ec335ed43f7ae4d366c62c2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.