Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/libvirtd: correct spelling #89240

merged 1 commit into from Jun 1, 2020


Copy link

@jakobrs jakobrs commented May 31, 2020

formally -> formerly

Motivation for this change

It's a spelling error.

Things done

I can't imagine this is going to break anything, but I'll try to build the manual soon myself.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
formally -> formerly
Copy link

@hyperfekt hyperfekt left a comment

LGTM; thanks for the contribution!

Maybe you could even change 'guest' to 'guests' while you're at it, the singular (to me) makes it sound like a per-guest option when it really isn't. But I'll leave that up to you.

@Ma27 Ma27 merged commit 78ca0c5 into NixOS:master Jun 1, 2020
14 checks passed
@jakobrs jakobrs deleted the formally-to-formerly branch Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants