Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.cachix: dontCheck #89272

Merged
merged 1 commit into from Jun 1, 2020
Merged

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented May 31, 2020

Motivation for this change

I guess since it's a channel blocker, it can go to master instead of haskell-updates? cc: @cdepillabout

Fixes #89255

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Jun 1, 2020

@vcunat How urgent is unblocking the channel?

The easiest thing here might be not to merge this in, but wait until @domenkozar fixes it in cachix upstream, makes a release, and it gets pulled into the haskell package set.

cc @peti about this as well.

@vcunat
Copy link
Member

@vcunat vcunat commented Jun 1, 2020

Only nixpkgs-unstable channel depends on that (not sure why it's committed that way), so I'd personally wait at least 24h for a reaction. Most Linux-based people use nixos-* channels, I think, so this one would be mainly for macOS.

@domenkozar
Copy link
Member

@domenkozar domenkozar commented Jun 1, 2020

This makes sense to do while I fix it properly and release.

@domenkozar domenkozar merged commit 48fc7fc into NixOS:master Jun 1, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants