Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/stale.yml: quote labels #89278

Merged
merged 1 commit into from Jun 1, 2020
Merged

.github/stale.yml: quote labels #89278

merged 1 commit into from Jun 1, 2020

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Jun 1, 2020

cc @ryantm

We might want to change this to use actions/stale as the probot repo doesn't seem to be very active.

Copy link
Member

@ryantm ryantm left a comment

Its our intention for this to work with pull requests too.

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Jun 1, 2020

Fixed, I didn't notice that PRs are mentioned in the RFC.

@zowoq zowoq changed the title .github/stale.yml: restrict to issues, quote labels .github/stale.yml: quote labels Jun 1, 2020
ryantm
ryantm approved these changes Jun 1, 2020
@ryantm ryantm merged commit 6756194 into NixOS:master Jun 1, 2020
13 checks passed
@zowoq zowoq deleted the stale branch Jun 1, 2020
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jun 1, 2020

Could we disable it for pull requests that are drafts? I have many pull requests in my queue but sometimes they are hanging there for years until I find time to finish them.

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Jun 1, 2020

The bot doesn't consider draft PRs to be different currently.

Having a WIP label and adding that to exemptLabels would be the closest we can do for now.

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Jun 1, 2020

In addition to labels we could enable these:

# Set to true to ignore issues in a project (defaults to false)
exemptProjects: false

# Set to true to ignore issues in a milestone (defaults to false)
exemptMilestones: false

# Set to true to ignore issues with an assignee (defaults to false)
exemptAssignees: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants