Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATS2 0.4.0 and support for MacOS builds #89283

Open
wants to merge 1 commit into
base: master
from

Conversation

@avanov
Copy link

avanov commented Jun 1, 2020

Motivation for this change

Current master branch doesn't contain a derivation for the current stable ATS2 (0.4.0), and MacOS is exempt from supported platforms

Things done
  • ATS2 version is upgraded to 0.4.0
  • ATS2-Contrib and ATS2 tarballs have appropriate sha256 checksums
  • metadata now contains platforms.darwin - this is possible through explicit passing of gccStdenv to the derivation on Darwin.
  • as I use Jetbrains' IDEs heavily, a corresponding gitignore entry was added.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

# jetbrains IDEs
.idea/
Comment on lines +22 to +24

This comment has been minimized.

Copy link
@ttuegel

ttuegel Jun 24, 2020

Member

Rather than put this in the shared .gitingore file, it would be a better to ignore it locally by putting it in `.git/info/exclude'.

This comment has been minimized.

Copy link
@avanov

avanov Jun 24, 2020

Author

I'm using the same repo on multiple laptops/machines, and manual handling of these sounds not very optimal, unless there's a very good reason not to share this ignore rule universally. In what situation is it not advisable to ignore .idea folder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.