Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tachyon: install header files #89285

merged 1 commit into from Jun 3, 2020

tachyon: install header files #89285

merged 1 commit into from Jun 3, 2020


Copy link

@rmcgibbo rmcgibbo commented Jun 1, 2020

Motivation for this change

Downstream packages that link against tachyon need the header files, but they were not being installed (include/ was empty).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@ofborg ofborg bot requested a review from 7c6f434c Jun 1, 2020
@7c6f434c 7c6f434c merged commit 4f9053c into NixOS:master Jun 3, 2020
16 checks passed
@rmcgibbo rmcgibbo deleted the tachyon branch Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants