Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold: 1.9.1 -> 1.10.1 #89291

Merged
merged 1 commit into from Jun 4, 2020
Merged

skaffold: 1.9.1 -> 1.10.1 #89291

merged 1 commit into from Jun 4, 2020

Conversation

@dsyer
Copy link
Contributor

dsyer commented Jun 1, 2020

There's a bug in 1.9.1 where skaffold debug adds a spurious args: "" to the deployment manifest. It was fixed in 1.10. Supersedes #87826 (can someone please tell me what to do to get these merged?).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
There's a bug in 1.9.1 where `skaffold debug` adds a spurious `args: ""` to the deployment manifest. It was fixed in 1.10.
Copy link
Member

vdemeester left a comment

LGTM 🐯

@bhipple
Copy link
Contributor

bhipple commented Jun 4, 2020

Result of nixpkgs-review pr 89291 1

1 package built:
- skaffold
@bhipple
bhipple approved these changes Jun 4, 2020
@bhipple bhipple merged commit 2068c82 into NixOS:master Jun 4, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7651f7"; rev="f7651f707493bdb689e796dcaa741862e8243c18"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7651f7"; rev="f7651f707493bdb689e796dcaa741862e8243c18"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7651f7"; rev="f7651f707493bdb689e796dcaa741862e8243c18"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7651f7"; rev="f7651f707493bdb689e796dcaa741862e8243c18"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7651f7"; rev="f7651f707493bdb689e796dcaa741862e8243c18"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7651f7"; rev="f7651f707493bdb689e796dcaa741862e8243c18"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7651f7"; rev="f7651f707493bdb689e796dcaa741862e8243c18"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
skaffold, skaffold.passthru.tests on aarch64-linux Success
Details
skaffold, skaffold.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.