Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra-unstable: 2020-04-16 -> 2020-06-01 #89297

Merged
merged 1 commit into from Jun 9, 2020
Merged

hydra-unstable: 2020-04-16 -> 2020-06-01 #89297

merged 1 commit into from Jun 9, 2020

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 1, 2020

Motivation for this change

Update Hydra to latest master.


Should we also backport this? Needs backport for #89305.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
andir
andir approved these changes Jun 1, 2020
Copy link
Member

@andir andir left a comment

Looks good. Tests did execute locally but I haven't actually tried to upgrade a hydra instance to this PR.

@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Jun 2, 2020

Fixed hydra-send-stats in NixOS/hydra#773, migration went well.

@Ma27 Ma27 requested a review from andir Jun 2, 2020
@edolstra edolstra merged commit 51e8a82 into NixOS:master Jun 9, 2020
17 checks passed
@Ma27 Ma27 deleted the bump-hydra branch Jun 9, 2020
@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Jun 9, 2020

Currently working on backporting this.

@Ma27
Copy link
Member Author

@Ma27 Ma27 commented Jun 9, 2020

Backported as 92d5b1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants