Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coz: fix python shebang #89306

merged 1 commit into from Jun 4, 2020


Copy link

@minijackson minijackson commented Jun 1, 2020

Motivation for this change

Currently, the coz package installs the coz script directly, which uses the environment's Python. This should make the closure depend on Python 3 and fixes the shebang.

Note: while the script uses Python2.7, the README says that Python 3 is recommended, and I've tested the script with Python 3 a bit, and seems to run just fine.

This also removes the unset of PYTHONPATH, which is not done by wrapPythonPrograms, so I'm paging @zimbatm to ask if he still has the same issue with this method.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
zimbatm approved these changes Jun 1, 2020
Copy link

@zimbatm zimbatm left a comment

I am not using it right now. If it works for you then it's good to merge.

Copy link

@bhipple bhipple commented Jun 4, 2020

Result of nixpkgs-review pr 89306 1

1 package built:
- coz

bhipple approved these changes Jun 4, 2020
@bhipple bhipple merged commit 9fc6768 into NixOS:master Jun 4, 2020
16 checks passed
@minijackson minijackson deleted the coz-fix-python-shebang branch Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants