Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] sane-airscan: 0.99.0 -> 0.99.3 #89320

Merged
merged 1 commit into from Jun 15, 2020

Conversation

@zaninime
Copy link
Contributor

zaninime commented Jun 1, 2020

Motivation for this change

Backport of #89319. Includes important bugfixes and it's backward-compatible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@prusnak
Copy link
Member

prusnak commented Jun 1, 2020

This PR does not fit CONTRIBUTING.md

You should get your commit to master merged first, only then create the backport commit using git cherry-pick -x which makes it very easy to verify the change has been already merged to master first.

Also the PR title should start with [20.03] not [backport].

(cherry picked from commit 07d3ca8)
@zaninime zaninime force-pushed the zaninime:sane-airscan-update-20.03 branch from 5408790 to 8759f46 Jun 8, 2020
@zaninime zaninime changed the title [backport] sane-airscan: 0.99.0 -> 0.99.3 [20.03] sane-airscan: 0.99.0 -> 0.99.3 Jun 8, 2020
@zaninime
Copy link
Contributor Author

zaninime commented Jun 8, 2020

@prusnak fixed. Thanks.

@zaninime
Copy link
Contributor Author

zaninime commented Jun 15, 2020

@marsam @prusnak any chance you can have a look into this one too? Thanks.

@marsam marsam merged commit ddeb47c into NixOS:release-20.03 Jun 15, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8759f46"; rev="8759f46c663011f3a4e7f4ed94355495ceaa9ce6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8759f46"; rev="8759f46c663011f3a4e7f4ed94355495ceaa9ce6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8759f46"; rev="8759f46c663011f3a4e7f4ed94355495ceaa9ce6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8759f46"; rev="8759f46c663011f3a4e7f4ed94355495ceaa9ce6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8759f46"; rev="8759f46c663011f3a4e7f4ed94355495ceaa9ce6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8759f46"; rev="8759f46c663011f3a4e7f4ed94355495ceaa9ce6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8759f46"; rev="8759f46c663011f3a4e7f4ed94355495ceaa9ce6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sane-airscan, sane-airscan.passthru.tests on aarch64-linux Success
Details
sane-airscan, sane-airscan.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.