Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_1_13: 1.13.11 -> 1.13.12 #89333

Merged
merged 1 commit into from Jun 13, 2020
Merged

go_1_13: 1.13.11 -> 1.13.12 #89333

merged 1 commit into from Jun 13, 2020

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Jun 1, 2020

https://golang.org/doc/devel/release.html#go1.13.minor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jun 2, 2020

FYI, I get following build failure on Ubuntu 18.04 (x86-64) using nix-review pr 89333:
Looks similar issue to #89334 failure on OfBorg aarch64.

code 1; last 10 log lines:
  ok       cmd/link        6.427s
  ok     cmd/link/internal/ld    2.493s
  ok     cmd/link/internal/sym   0.031s
  ok     cmd/nm  5.123s
  ok     cmd/objdump     3.774s
  ok     cmd/pack        2.343s
  ok     cmd/trace       0.044s
  ok     cmd/vet 7.083s
  FAIL
  2020/06/02 13:18:28 Failed: exit status 1
cannot build derivation '/nix/store/1945w6li2vqcvp2s3mbiy4qzjqk2p8hb-env.drv': 1 dependencies couldn't be built
[1 built (1 failed), 10 copied (287.6 MiB), 46.8 MiB DL]
error: build of '/nix/store/1945w6li2vqcvp2s3mbiy4qzjqk2p8hb-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/89333
1 package failed to build:
go_1_13

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Jun 4, 2020

#89334 (comment)

Looks like it doesn't occur very often, I'll let the package maintainers decide if we want to disable that particular test or not.

@marsam marsam merged commit 1cd56fc into NixOS:master Jun 13, 2020
17 checks passed
@zowoq zowoq deleted the go_1_13 branch Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants