Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: 1.14.3 -> 1.14.4 #89334

Merged
merged 2 commits into from Jun 13, 2020
Merged

go: 1.14.3 -> 1.14.4 #89334

merged 2 commits into from Jun 13, 2020

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Jun 1, 2020

https://golang.org/doc/devel/release.html#go1.14.minor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

8d41f9f

Targeting staging-next as the previous go version bump hasn't landed in master yet.

@drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Jun 2, 2020

Diff LGTM, but failing tests on OfBorg aarch64-linux.

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Jun 2, 2020

@ofborg build go

@drewrisinger drewrisinger mentioned this pull request Jun 2, 2020
10 tasks
@c00w
Copy link
Contributor

@c00w c00w commented Jun 4, 2020

Failure message is

--- FAIL: TestDontCacheBrokenHTTP2Conn (0.05s)
    transport_test.go:6079: for iteration 5, doBreak=false; unexpected error Get "https://127.0.0.1:40267": some write error
    transport_test.go:6083: GotConn calls = 0; want 1

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Jun 4, 2020

Looks like it doesn't occur very often, I'll let the package maintainers decide if we want to disable that particular test or not.

@FRidh FRidh added this to WIP in Staging via automation Jun 4, 2020
@c00w
Copy link
Contributor

@c00w c00w commented Jun 5, 2020

If it's flaky, can we file a report with the go team and disable it? I think we have lots of other disabled go tests + they passed on upstream so I'm not super concerned about a single test failing.

@c00w
Copy link
Contributor

@c00w c00w commented Jun 5, 2020

I'm also not a maintainer and can't merge :D so this is just my personal opinion.

@mdlayher
Copy link
Member

@mdlayher mdlayher commented Jun 7, 2020

Possibly related? golang/go#35113

@Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 8, 2020

Does cherry-picking golang/go@ea1437a fix the error?

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Jun 8, 2020

Does cherry-picking golang/go@ea1437a fix the error?

golang/go@ea1437a
On my laptop, before this commit, TestDontCacheBrokenHTTP2Conn
failed 66 times out of 20,000. With this commit, I see 0 out of 20,000.

I've added the patch but it might be had to tell if it fixes it or not.

The patch doesn't apply for 1.13. As nothing depends on it, it will be EOL soon and we've already deleted it once I'm not going to bother trying to patch it.

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Jun 8, 2020

@ofborg build go

@zowoq zowoq changed the base branch from staging-next to staging Jun 10, 2020
@Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 10, 2020

Tests seems to pass now.

@GrahamcOfBorg build docker

@Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 10, 2020

@GrahamcOfBorg build direnv

Copy link
Member

@mdlayher mdlayher left a comment

LGTM. I am still fairly new to NixOS and am slightly concerned by pulling in patches that aren't part of the upstream Go 1.14.4, but it seems that is the usual pattern here.

@marsam marsam merged commit c2ce7eb into NixOS:staging Jun 13, 2020
22 of 24 checks passed
Staging automation moved this from WIP to Done Jun 13, 2020
@zowoq zowoq deleted the go_1_14 branch Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants