Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: 1.43.0 -> 1.44.1 #89576

Merged
merged 2 commits into from Jul 2, 2020
Merged

rustc: 1.43.0 -> 1.44.1 #89576

merged 2 commits into from Jul 2, 2020

Conversation

@alyssais
Copy link
Member

alyssais commented Jun 6, 2020

I wasn’t able to build thunderbird and Firefox for unrelated reasons (unless it’s gone away on a more recent staging I’ll open a PR for that shortly), but with those issues addressed I’ve successfully built Firefox and Thunderbird with Rust 1.44, so they shouldn’t block the rust update.

Could a Darwin user please nix-build -A fd for me please?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lblasc
lblasc approved these changes Jun 7, 2020
Copy link
Member

LnL7 left a comment

Too many other things failed on staging so can't test it properly as is.

@Mic92
Copy link
Contributor

Mic92 commented Jun 8, 2020

cannot test any cargo-based build on aarch64 because one git test fail on our community aarch64 builder. rustc builds itself.

@FRidh FRidh added this to WIP in Staging via automation Jun 13, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Jun 13, 2020
@FRidh FRidh added this to the 20.09 milestone Jun 19, 2020
@FRidh
Copy link
Member

FRidh commented Jun 19, 2020

Reminder for testing this PR.

@Ma27
Ma27 approved these changes Jun 19, 2020
Copy link
Member

Ma27 left a comment

Tested this while investigating #89481, LGTM 👍

Staging automation moved this from Needs review to Ready Jun 19, 2020
@Mic92
Copy link
Contributor

Mic92 commented Jun 21, 2020

I will give aarch64 another try.

@Mic92
Copy link
Contributor

Mic92 commented Jun 22, 2020

aarch64 builds now fd properly.

@marsam marsam mentioned this pull request Jun 23, 2020
4 of 10 tasks complete
@L-as
Copy link
Contributor

L-as commented Jun 27, 2020

This should be updated to 1.44.1 IMO. Apparently 1.44.0 had several regressions: https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1441-2020-06-18

alyssais added 2 commits Jun 5, 2020
Nothing seems to need this to build any more.
@alyssais alyssais force-pushed the alyssais:rust branch from b280dbe to 05182c7 Jun 30, 2020
@alyssais
Copy link
Member Author

alyssais commented Jun 30, 2020

@FRidh FRidh changed the title rustc: 1.43.0 -> 1.44.0 rustc: 1.43.0 -> 1.44.1 Jul 2, 2020
@FRidh FRidh merged commit 204d583 into NixOS:staging Jul 2, 2020
17 of 18 checks passed
17 of 18 checks passed
rustc, rustc.passthru.tests on x86_64-darwin
Details
rustc.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05182c7"; rev="05182c7bd2c8df03bd0456fda42697d2a56e277f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05182c7"; rev="05182c7bd2c8df03bd0456fda42697d2a56e277f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05182c7"; rev="05182c7bd2c8df03bd0456fda42697d2a56e277f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05182c7"; rev="05182c7bd2c8df03bd0456fda42697d2a56e277f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05182c7"; rev="05182c7bd2c8df03bd0456fda42697d2a56e277f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05182c7"; rev="05182c7bd2c8df03bd0456fda42697d2a56e277f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05182c7"; rev="05182c7bd2c8df03bd0456fda42697d2a56e277f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
rustc, rustc.passthru.tests on aarch64-linux Success
Details
rustc, rustc.passthru.tests on x86_64-linux Success
Details
Staging automation moved this from Ready to Done Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.