Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pantalaimon: fix build #89694

Merged
merged 3 commits into from Jun 20, 2020
Merged

pantalaimon: fix build #89694

merged 3 commits into from Jun 20, 2020

Conversation

@symphorien
Copy link
Contributor

symphorien commented Jun 6, 2020

Motivation for this change

pantalaimon does not build on nixos-unstable

Some updates were needed. peewee tests now require psycopg.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@FRidh
Copy link
Member

FRidh commented Jun 13, 2020

many package updates are now in #89723. Best rebase this on staging-next once those updates land there.

@symphorien symphorien force-pushed the symphorien:pan3 branch from 8b553a1 to 0707fe7 Jun 15, 2020
@ofborg ofborg bot requested review from rvl and dotlambda Jun 15, 2020
@symphorien symphorien force-pushed the symphorien:pan3 branch from 162fdd8 to 915b1d8 Jun 15, 2020
@symphorien symphorien changed the base branch from master to staging-next Jun 15, 2020
@symphorien
Copy link
Contributor Author

symphorien commented Jun 15, 2020

rebased on staging-next. I don't know why some r-ryantm and others commits are here, though.

@symphorien symphorien force-pushed the symphorien:pan3 branch from 087d196 to d1b8e8f Jun 16, 2020
@ofborg ofborg bot requested a review from dotlambda Jun 16, 2020
Copy link
Contributor

simonchatts left a comment

I've confirmed that this works with my dependencies on janus.

symphorien added 3 commits Jun 6, 2020
tests don't pass without psycopg2 support:
Exception: Your version of psycopg2 does not support JSON.
@symphorien
Copy link
Contributor Author

symphorien commented Jun 20, 2020

rebased on master, tested that pantalaimon builds and run.

Copy link
Contributor

jonringer left a comment

LGTM

nixpkgs-review freezing on python38Packages.uvloop, failures don't seem to be associated to any of these bumps

@jonringer jonringer merged commit dee5584 into NixOS:master Jun 20, 2020
18 checks passed
18 checks passed
home-assistant, home-assistant.passthru.tests, ipfs, ipfs.passthru.tests, libinput, libinput.passthru.tests, pantalaimon, pantalaimon.passthru.tests, python, python.passthru.tests, skopeo, skopeo.passthru.tests on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6905d6"; rev="b6905d6f914d89c523dadb4bf33d6c9d9544ea01"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6905d6"; rev="b6905d6f914d89c523dadb4bf33d6c9d9544ea01"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6905d6"; rev="b6905d6f914d89c523dadb4bf33d6c9d9544ea01"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6905d6"; rev="b6905d6f914d89c523dadb4bf33d6c9d9544ea01"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6905d6"; rev="b6905d6f914d89c523dadb4bf33d6c9d9544ea01"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6905d6"; rev="b6905d6f914d89c523dadb4bf33d6c9d9544ea01"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6905d6"; rev="b6905d6f914d89c523dadb4bf33d6c9d9544ea01"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
home-assistant, home-assistant.passthru.tests, ipfs, ipfs.passthru.tests, libinput, libinput.passthru.tests, pantalaimon, pantalaimon.passthru.tests, python, python.passthru.tests, skopeo, skopeo.passthru.tests on x86_64-linux Success
Details
pantalaimon, pantalaimon.passthru.tests on aarch64-linux Success
Details
pantalaimon, pantalaimon.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.