Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python35: add EOL announcement #89761

Closed
wants to merge 1 commit into from
Closed

Conversation

@wamserma
Copy link
Contributor

@wamserma wamserma commented Jun 7, 2020

Motivation for this change

Python 3.5 will be EOL three months from now. The warning hopefully prevents any dependencies on Python 3.5 sneaking into release 20.09.
External dependencies (e.g. in NUR) get a visible notification and have enough time to migrate.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review pr 89761"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@wamserma wamserma requested a review from FRidh as a code owner Jun 7, 2020
@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Jun 7, 2020

$ nixpkgs-review pr 89761
[...]
Nothing changed.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Jun 7, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/upcoming-python-breakage/7554/6

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jun 7, 2020

Unfortunately, it is not possible to use warnings like this because they will be printed by nix-env evaluation and trip up other tooling like you can see with ofborg here.

@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Jun 8, 2020

Yey, it trips ofborg, but there should be no more references to python35 once #89755 is merged, so ofborg should not evaluate this far in any other PR. Don' t know about Hydra, but local evaluations should not fail as it only prints the warning, pretty much as with the mlocate service.

@wamserma wamserma closed this Oct 15, 2020
@wamserma wamserma deleted the python35-deprecation branch Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants