Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shards: 0.10.0 -> 0.11.0 #89863

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented Jun 9, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/crystal-lang/shards/releases.

meta.description for shards is: "Dependency manager for the Crystal language"

meta.homepage for shards is: "https://crystal-lang.org/"

meta.changelog for shards is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
15 total rebuild path(s)

5 package rebuild(s)

5 x86_64-linux rebuild(s)
5 i686-linux rebuild(s)
5 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
ameba
gitAndTools.thicket
icr
mint
shards
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/19k4445v57r7l3cb1vb3i9pcy16x8ghs-shards-0.11.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A shards https://github.com/r-ryantm/nixpkgs/archive/d09ddbeb2fbe20be78e803af0f18b558ba76e274.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/19k4445v57r7l3cb1vb3i9pcy16x8ghs-shards-0.11.0
ls -la /nix/store/19k4445v57r7l3cb1vb3i9pcy16x8ghs-shards-0.11.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

2 packages failed to build:
- icr
- mint
3 packages built:
- ameba
- gitAndTools.thicket
- shards

Maintainer pings

cc @peterhoeg for testing.

@peterhoeg
Copy link
Member

peterhoeg commented Jun 9, 2020

@NixOS/crystal-lang - we cannot just do this in isolation as it drops compatibility with crystal < 0.34 so we need to introduce 0.10 and 0.11 side by side.

@manveru
Copy link
Contributor

manveru commented Jun 10, 2020

Yeah, I'm gonna work on Crystal 0.35.0, apparently it already ships with shards now, so we might be able to ignore this entirely?

@manveru
Copy link
Contributor

manveru commented Jun 10, 2020

OK, I probably misread what Shards v0.11.1 is bundled in this release. means, it definitely is not bundled with Crystal itself yet. So yeah, we will need both versions.
Maybe we should try to work one something like crystal.withPackages that automatically selects the correct shards version?

@manveru manveru mentioned this pull request Jun 10, 2020
0 of 10 tasks complete
@manveru
Copy link
Contributor

manveru commented Jun 10, 2020

So the new lock format actually is really nice, we can now do offline conversions of locks and with IFD we don't even need crystal2nix anymore.
I made little hacky transformer at https://gist.github.com/manveru/b04081bc29036f64587b4fa3d57daa0d that you can try

@manveru
Copy link
Contributor

manveru commented Jun 10, 2020

That said, our new crystal2nix could simply do the yaml2json conversion and we'd be golden for inclusion in nixpkgs!

@peterhoeg
Copy link
Member

peterhoeg commented Jun 11, 2020

Nice!

Maybe we should try to work one something like crystal.withPackages that automatically selects the correct shards version?

How about simply slipstreaming the supported shards version into our crystal packages?

@r-ryantm r-ryantm closed this Jun 11, 2020
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/shards branch Jun 11, 2020
@ryantm ryantm restored the r-ryantm:auto-update/shards branch Jun 11, 2020
@ryantm ryantm reopened this Jun 11, 2020
@r-ryantm r-ryantm closed this Jun 14, 2020
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/shards branch Jun 14, 2020
@ryantm ryantm restored the r-ryantm:auto-update/shards branch Jun 14, 2020
@ryantm ryantm reopened this Jun 14, 2020
@peterhoeg
Copy link
Member

peterhoeg commented Jun 23, 2020

How about simply slipstreaming the supported shards version into our crystal packages?

Actually, come to think of it, that's a bad idea.

Whatever work goes into it now, is going to be temporary in nature as v1.0 is supposed to launch sometime later this year after which we shouldn't have to care about all these breaking changes.

@r-ryantm r-ryantm closed this Jul 1, 2020
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/shards branch Jul 1, 2020
@ryantm ryantm restored the r-ryantm:auto-update/shards branch Jul 1, 2020
@ryantm ryantm reopened this Jul 1, 2020
@peterhoeg peterhoeg mentioned this pull request Jul 9, 2020
1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.