Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sox: Add WavPack support #90172

Merged
merged 1 commit into from Oct 1, 2020
Merged

sox: Add WavPack support #90172

merged 1 commit into from Oct 1, 2020

Conversation

@AluisioASG
Copy link
Contributor

@AluisioASG AluisioASG commented Jun 12, 2020

Motivation for this change

r128gain's tests include processing some WavPack files with sox. Allow opting into linking with wavpack so those tests can be run.

I don't know how prevalent usage of WavPack is nor if it should be linked by default, but went that way because all other free dependencies are enabled by default.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
r128gain's tests include processing some WavPack files with sox.  Allow
opting into linking with wavpack so those tests can be run.
@AluisioASG
Copy link
Contributor Author

@AluisioASG AluisioASG commented Jun 24, 2020

/marvin opt-in

Do we need a review from @MarcWeber as well?

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 24, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Jun 24, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@AluisioASG
Copy link
Contributor Author

@AluisioASG AluisioASG commented Sep 30, 2020

This still builds.

/status needs_reviewer

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Sep 30, 2020

@glittershark please review.

Copy link
Member

@glittershark glittershark left a comment

LGTM!

@glittershark
Copy link
Member

@glittershark glittershark commented Oct 1, 2020

/status needs_merger

@timokau
Copy link
Member

@timokau timokau commented Oct 1, 2020

Thanks for the review @glittershark :)

@timokau timokau merged commit cb5a4de into NixOS:master Oct 1, 2020
16 checks passed
@AluisioASG AluisioASG deleted the aasg/sox-wv branch Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants