Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esptool: 2.7 -> 2.8 #90351

Open
wants to merge 1 commit into
base: master
from
Open

esptool: 2.7 -> 2.8 #90351

wants to merge 1 commit into from

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented Jun 14, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/espressif/esptool/releases.

meta.description for esptool is: "ESP8266 and ESP32 serial bootloader utility"

meta.homepage for esptool is: "https://github.com/espressif/esptool"

meta.changelog for esptool is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
5 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
esphome
esptool
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/48888zs7iv45jhq8hnxfkhc2h5p6qilc-esptool-2.8 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A esptool https://github.com/r-ryantm/nixpkgs/archive/fdbbe3a213cbbb982bd1054d23825397c9fffe56.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/48888zs7iv45jhq8hnxfkhc2h5p6qilc-esptool-2.8
ls -la /nix/store/48888zs7iv45jhq8hnxfkhc2h5p6qilc-esptool-2.8/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

2 packages built:
- esphome
- esptool

Maintainer pings

cc @dezgeg @dotlambda for testing.

Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 90351 1

2 packages built:
- esphome
- esptool

Copy link
Member

dotlambda left a comment

Same problem as in #72492.

@jonringer
Copy link
Contributor

jonringer commented Jun 17, 2020

wrapping isn't going to compose with module imports, seems like we should be patching the source to ensure that the correct behavior happens

@dotlambda
Copy link
Member

dotlambda commented Jun 18, 2020

This is not packaged as a module.

@r-ryantm r-ryantm closed this Jul 1, 2020
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/esptool branch Jul 1, 2020
@ryantm ryantm restored the r-ryantm:auto-update/esptool branch Jul 1, 2020
@ryantm ryantm reopened this Jul 1, 2020
@ofborg ofborg bot requested a review from dotlambda Jul 1, 2020
@makefu
Copy link
Contributor

makefu commented Sep 15, 2020

pretty sure this PR is ready for being merged

@dotlambda
Copy link
Member

dotlambda commented Sep 16, 2020

@makefu
Copy link
Contributor

makefu commented Sep 16, 2020

No, see #72492 (comment)

oh damn, i have missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.