Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tremor location fix #90464

Merged
merged 1 commit into from Jul 2, 2020
Merged

Tremor location fix #90464

merged 1 commit into from Jul 2, 2020

Conversation

@fomichevmi
Copy link
Contributor

fomichevmi commented Jun 15, 2020

Tremor is not available any longer via 'https://git.xiph.org/tremor.git'.

Motivation for this change

Tremor is not accessible via https://git.xiph.org/tremor.git

Things done

Outdated git location replaced with actual

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

puzzlewolf left a comment

Thanks for your first PR! 🎉

As the repository for Tremor is now hosted on gitlab, I think it would be preferable to use fetchFromGitLab instead of the generic fetchgit. Do you feel up for changing that?

Also, when you're done: Please squash your commits into one, with a commit message matching CONTRIBUTING.md.

@fomichevmi fomichevmi changed the title Tremor location fix Draft: Tremor location fix Jun 15, 2020
@fomichevmi fomichevmi force-pushed the fomichevmi:patch-1 branch 2 times, most recently from f691e1e to ca6bbdf Jun 15, 2020
@fomichevmi fomichevmi changed the title Draft: Tremor location fix Tremor location fix Jun 16, 2020
@fomichevmi
Copy link
Contributor Author

fomichevmi commented Jun 16, 2020

Thanks for your first PR! 🎉

As the repository for Tremor is now hosted on gitlab, I think it would be preferable to use fetchFromGitLab instead of the generic fetchgit. Do you feel up for changing that?

Also, when you're done: Please squash your commits into one, with a commit message matching CONTRIBUTING.md.

I think, it's ready

@fomichevmi fomichevmi force-pushed the fomichevmi:patch-1 branch from ca6bbdf to 9a4c58d Jun 16, 2020
@fomichevmi fomichevmi force-pushed the fomichevmi:patch-1 branch from 9a4c58d to 5399b4f Jun 16, 2020
@puzzlewolf
Copy link
Contributor

puzzlewolf commented Jun 16, 2020

This PR causes a lot of rebuilds, see tags added by @GrahamcOfBorg. It should be made against the staging branch (see manual).

Ideally, you can just change the base branch in the github interface for this PR.

@FRidh FRidh merged commit 0a9d994 into NixOS:master Jul 2, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5399b4f"; rev="5399b4f9b4929bc2d26c74ff4c3ee7b79e9db144"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5399b4f"; rev="5399b4f9b4929bc2d26c74ff4c3ee7b79e9db144"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5399b4f"; rev="5399b4f9b4929bc2d26c74ff4c3ee7b79e9db144"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5399b4f"; rev="5399b4f9b4929bc2d26c74ff4c3ee7b79e9db144"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5399b4f"; rev="5399b4f9b4929bc2d26c74ff4c3ee7b79e9db144"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5399b4f"; rev="5399b4f9b4929bc2d26c74ff4c3ee7b79e9db144"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5399b4f"; rev="5399b4f9b4929bc2d26c74ff4c3ee7b79e9db144"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tremor, tremor.passthru.tests on aarch64-linux Success
Details
tremor, tremor.passthru.tests on x86_64-linux Success
Details
@FRidh
Copy link
Member

FRidh commented Jul 2, 2020

ah, indeed, should have gone to staging. Oh well, it's not too bad in this case.

@puzzlewolf
Copy link
Contributor

puzzlewolf commented Jul 2, 2020

@FRidh What number of rebuilds would you consider a rough threshold for targeting staging instead of master? The manual speaks of "mass rebuilds", but isn't clear what that is xD. Maybe when the tag goes red, i.e. 501+?

@FRidh
Copy link
Member

FRidh commented Jul 2, 2020

Yes, we draw the line at 500.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.