Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-revise: 0.5.1 -> 0.6.0 #90578

Merged
merged 1 commit into from Jun 23, 2020
Merged

git-revise: 0.5.1 -> 0.6.0 #90578

merged 1 commit into from Jun 23, 2020

Conversation

@marsam
Copy link
Contributor

marsam commented Jun 16, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@marsam marsam requested review from FRidh and jonringer as code owners Jun 16, 2020
@ofborg ofborg bot added the 6.topic: python label Jun 16, 2020
@ofborg ofborg bot requested a review from emilazy Jun 16, 2020
checkInputs = [ tox pytest pylint mypy black ];

checkPhase = ''
tox
'';
checkInputs = [ git pytestCheckHook ];
Comment on lines -23 to +23

This comment has been minimized.

Copy link
@emilazy

emilazy Jun 16, 2020

Member

I presume this skips running the type-checking, linting and formatting checks from the tox.ini. Not sure if all of those are worth keeping (the mypy probably is at least), but felt worth noting.

@Ma27 Ma27 merged commit 2ab0d4e into NixOS:master Jun 23, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
git-revise, git-revise.passthru.tests on aarch64-linux Success
Details
git-revise, git-revise.passthru.tests on x86_64-darwin Success
Details
git-revise, git-revise.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bb70e10"; rev="bb70e10541ecb85d4f908db362e3d34846b6302a"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bb70e10"; rev="bb70e10541ecb85d4f908db362e3d34846b6302a"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bb70e10"; rev="bb70e10541ecb85d4f908db362e3d34846b6302a"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bb70e10"; rev="bb70e10541ecb85d4f908db362e3d34846b6302a"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bb70e10"; rev="bb70e10541ecb85d4f908db362e3d34846b6302a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bb70e10"; rev="bb70e10541ecb85d4f908db362e3d34846b6302a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="bb70e10"; rev="bb70e10541ecb85d4f908db362e3d34846b6302a"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.