Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.canopen: 0.5.1 -> 1.1.0 #90588

Merged
merged 1 commit into from Jul 2, 2020

Conversation

@Emantor
Copy link
Contributor

Emantor commented Jun 16, 2020

Motivation for this change

Much newer version available, re-enable tests and use fetchPypi.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Bump version for the python canopen module, move to fetchPypi and
re-enable tests.
@Emantor Emantor requested review from FRidh and jonringer as code owners Jun 16, 2020
@ofborg ofborg bot added the 6.topic: python label Jun 16, 2020
@ofborg ofborg bot requested a review from sorki Jun 16, 2020
@sorki
sorki approved these changes Jun 16, 2020
Copy link
Member

sorki left a comment

LGTM! Thank you!

@Enteee
Enteee approved these changes Jul 2, 2020
Copy link
Contributor

Enteee left a comment

LGTM

@nixos-discourse
Copy link

nixos-discourse commented Jul 2, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/179

@jonringer jonringer mentioned this pull request Jul 2, 2020
4 of 10 tasks complete
Copy link
Contributor

jonringer left a comment

LGTM

failures are broken on target branch

1 package failed to build:
python38Packages.canopen

2 packages built:
python27Packages.canopen python37Packages.canopen
@jonringer jonringer merged commit f32a865 into NixOS:master Jul 2, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="da1e22f"; rev="da1e22fc3ccfb840d9b9a27c6ba7e76f37ce5c2a"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="da1e22f"; rev="da1e22fc3ccfb840d9b9a27c6ba7e76f37ce5c2a"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="da1e22f"; rev="da1e22fc3ccfb840d9b9a27c6ba7e76f37ce5c2a"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="da1e22f"; rev="da1e22fc3ccfb840d9b9a27c6ba7e76f37ce5c2a"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="da1e22f"; rev="da1e22fc3ccfb840d9b9a27c6ba7e76f37ce5c2a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="da1e22f"; rev="da1e22fc3ccfb840d9b9a27c6ba7e76f37ce5c2a"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="da1e22f"; rev="da1e22fc3ccfb840d9b9a27c6ba7e76f37ce5c2a"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Emantor Emantor deleted the Emantor:bump/python-canopen branch Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.