Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elinks: bump to newest version, thereby making it usable again #90593

Merged
merged 1 commit into from Aug 1, 2020

Conversation

@iblech
Copy link
Contributor

iblech commented Jun 16, 2020

Motivation for this change

elinks is a text-mode browser from the old times. I vividly remember that it was my main browser at some point. Alas, the current nixpkgs version of elinks is not really usable, as it fails with SSL errors on most sites. You can reproduce this yourself with

$ nix-shell -p elinks
$ elinks https://www.explainxkcd.com/wiki/index.php/Main_Page

or with most any site really.

This pull request packages the newest version, rendering it usable again. Since development of the official elinks repository seems to have paused, this pull request follows Debian in packaging felinks, a fork of elinks. We also adopt Debian's patches which make the build more reproducible and which implement defaults more adapted to today's age (for instance, to honor the caching behavior prescribed by web servers).

Since the nixpkgs package seemed to be unmaintained, I added myself as maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
preConfigure = ''
patchShebangs ./autogen.sh
./autogen.sh
'';

meta = {

This comment has been minimized.

Copy link
@IvarWithoutBones

IvarWithoutBones Jun 16, 2020

Contributor

Currently ofborg fails to evaluate this, as maintainers isn't in scope.

Suggested change
meta = {
meta = with stdenv.lib; {
description = "Full-featured text-mode web browser (package based on the fork felinks)";
homepage = "https://github.com/rkd77/felinks";
license = licenses.gpl2;
platforms = platforms.linux;
maintainers = with maintainers; [ iblech ];
};

This comment has been minimized.

Copy link
@iblech

iblech Jun 17, 2020

Author Contributor

Oops, thank you, I added the maintainers field at the last moment and didn't notice that it wasn't in scope. I also tried platforms.unix, I cannot test on macOS, but Hydra can, let's see!

@Ma27
Copy link
Member

Ma27 commented Jun 28, 2020

Conflicts with master atm.

@iblech iblech force-pushed the iblech:patch-19 branch from 0a7ac21 to 1a48e59 Jun 28, 2020
@iblech
Copy link
Contributor Author

iblech commented Jun 28, 2020

Thank you @Ma27, I just rebased to latest master and re-tested (alas only on Linux, not on macOS). I believe Borg will test darwin.

@xeji
Copy link
Contributor

xeji commented Jul 30, 2020

@GrahamcOfBorg build elinks

Copy link
Contributor

xeji left a comment

elinks builds and works fine but it seems you accidentally included an unrelated commit 1a48e59 . Please remove it.

@iblech iblech force-pushed the iblech:patch-19 branch from 1a48e59 to 71cfbba Jul 30, 2020
@iblech
Copy link
Contributor Author

iblech commented Jul 30, 2020

Oh, thanks for noticing! I just removed the stray commit. :-)

@ofborg ofborg bot removed the 6.topic: nixos label Jul 30, 2020
@xeji
xeji approved these changes Aug 1, 2020
@xeji xeji merged commit 19f5bb6 into NixOS:master Aug 1, 2020
17 of 18 checks passed
17 of 18 checks passed
editorconfig editorconfig
Details
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
elinks, elinks.passthru.tests on aarch64-linux Success
Details
elinks, elinks.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="71cfbba"; rev="71cfbba0724302a979e03044e5b0df18e2a2a282"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="71cfbba"; rev="71cfbba0724302a979e03044e5b0df18e2a2a282"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="71cfbba"; rev="71cfbba0724302a979e03044e5b0df18e2a2a282"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="71cfbba"; rev="71cfbba0724302a979e03044e5b0df18e2a2a282"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="71cfbba"; rev="71cfbba0724302a979e03044e5b0df18e2a2a282"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="71cfbba"; rev="71cfbba0724302a979e03044e5b0df18e2a2a282"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="71cfbba"; rev="71cfbba0724302a979e03044e5b0df18e2a2a282"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.