Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/taskserver: fix gnutls invocation #90718

Closed
wants to merge 1 commit into from

Conversation

@wamserma
Copy link
Contributor

wamserma commented Jun 18, 2020

test failed because gnutls-cli does not properly report connection
errors any more, fixed by increasing the debug level for gnutls-cli

Motivation for this change

Fixes #84507

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@wamserma
Copy link
Contributor Author

wamserma commented Jun 18, 2020

Note: This is a workaround and I also opened an issue upstream to see if this is a permanent change of behaviour:
https://gitlab.com/gnutls/gnutls/-/issues/1040

@wamserma
Copy link
Contributor Author

wamserma commented Jun 23, 2020

ping @aszlig

@aszlig
aszlig approved these changes Jun 23, 2020
Copy link
Member

aszlig left a comment

Eeeesh, this is very unfortunate. I guess until we get an answer from upstream it's fine to use this workaround for now.

nixos/tests/taskserver.nix Show resolved Hide resolved
test failed because gnutls-cli does not properly report connection
errors any more, fixed by increasing the debug level for gnutls-cli
@wamserma wamserma force-pushed the wamserma:fix-test-taskserver branch from 9a188bb to ca7811f Jun 23, 2020
@wamserma
Copy link
Contributor Author

wamserma commented Jun 23, 2020

Eeeesh, this is very unfortunate. I guess until we get an answer from upstream it's fine to use this workaround for now.

Luckily this is the only test using gnutls-cli.

@aszlig aszlig closed this in e435660 Jun 23, 2020
@aszlig
Copy link
Member

aszlig commented Jun 23, 2020

@wamserma: Merged, thanks for the fix :-)

@wamserma wamserma deleted the wamserma:fix-test-taskserver branch Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.