Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptsetup: 2.1.0 -> 2.3.3 #91017

Merged
merged 2 commits into from Jul 2, 2020
Merged

cryptsetup: 2.1.0 -> 2.3.3 #91017

merged 2 commits into from Jul 2, 2020

Conversation

@mmilata
Copy link
Member

mmilata commented Jun 18, 2020

Changes:

The python bindings were removed in 2.1.0.

Successfully booted my 20.03 on LUKS-encrypted root using this package.

Motivation for this change

Release notes told me:

All users of cryptsetup 2.x should upgrade to this version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mmilata
Copy link
Member Author

mmilata commented Jun 18, 2020

@ofborg test installer

The python bindings were dropped in cryptsetup-2.1.0:
https://gitlab.com/cryptsetup/cryptsetup/-/blob/master/docs/v2.1.0-ReleaseNotes#L63

However this did not cause the blivet build to fail nor did anyone
notice (cryptsetup-2.1.0 was introduced in nixos-19.09).
@mmilata mmilata requested review from FRidh and jonringer as code owners Jun 18, 2020
@ofborg ofborg bot added the 6.topic: python label Jun 18, 2020
@mmilata
Copy link
Member Author

mmilata commented Jun 18, 2020

Added 2c23cba that removes cryptsetup as a dependency of blivet since it breaks evaluation and the blivet cryptsetup support hasn't worked since nixos-19.09. cc @aszlig

@jtojnar
Copy link
Contributor

jtojnar commented Jun 21, 2020

@GrahamcOfBorg test installer.encryptedFSWithKeyfile installer.luksroot installer.luksroot-format2 installer.luksroot-format1

@jtojnar jtojnar merged commit 7e5bfbc into NixOS:staging Jul 2, 2020
18 checks passed
18 checks passed
tests.installer.encryptedFSWithKeyfile, tests.installer.luksroot, tests.installer.luksroot-format1, tests.installer.luksroot-format2 on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
cryptsetup, cryptsetup.passthru.tests on aarch64-linux Success
Details
cryptsetup, cryptsetup.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c23cba"; rev="2c23cba550c5495582f8d187f1584e0c484b0161"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c23cba"; rev="2c23cba550c5495582f8d187f1584e0c484b0161"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c23cba"; rev="2c23cba550c5495582f8d187f1584e0c484b0161"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c23cba"; rev="2c23cba550c5495582f8d187f1584e0c484b0161"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c23cba"; rev="2c23cba550c5495582f8d187f1584e0c484b0161"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c23cba"; rev="2c23cba550c5495582f8d187f1584e0c484b0161"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2c23cba"; rev="2c23cba550c5495582f8d187f1584e0c484b0161"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.installer.encryptedFSWithKeyfile, tests.installer.luksroot, tests.installer.luksroot-format1, tests.installer.luksroot-format2 on x86_64-linux Success
Details
@mmilata mmilata deleted the mmilata:cryptsetup-2.3.3 branch Jul 2, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jul 2, 2020

Tests passed and no further comments so let's just merge this.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.