Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.utc: unbreak #91103

Merged
merged 1 commit into from Jun 20, 2020
Merged

Conversation

@sternenseemann
Copy link
Member

sternenseemann commented Jun 19, 2020

Motivation for this change

Fix simple version constraint issue preventing utc from building

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sternenseemann sternenseemann requested a review from cdepillabout as a code owner Jun 19, 2020
@sternenseemann sternenseemann force-pushed the sternenseemann:unbreak-utc branch from 4d74aa4 to d39c818 Jun 19, 2020
@peti peti force-pushed the NixOS:haskell-updates branch 3 times, most recently from 02f9eb5 to 881e0cf Jun 19, 2020
@cdepillabout
Copy link
Member

cdepillabout commented Jun 20, 2020

@sternenseemann Thanks for this PR.

Could you do a couple things:

  • Rebase your commit onto the head of the haskell-updates branch. (It looks like an unfortunate timing that right after you sent this, the haskell-updates branch was updated).
  • Create an issue on the upstream repo asking for a new release to hackage (and put that link right into the nix code below the comment you've already added).

Once you do these two things, I'll be happy to merge this in.

@sternenseemann sternenseemann force-pushed the sternenseemann:unbreak-utc branch from d39c818 to 2f139e4 Jun 20, 2020
@sternenseemann
Copy link
Member Author

sternenseemann commented Jun 20, 2020

@cdepillabout should all be resolved now!

@cdepillabout
Copy link
Member

cdepillabout commented Jun 20, 2020

Builds for me, thanks for fixing this up!

@cdepillabout cdepillabout merged commit e6ba9ab into NixOS:haskell-updates Jun 20, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2f139e4"; rev="2f139e40c6c3abaa77937216600e2ae0431f2ce1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2f139e4"; rev="2f139e40c6c3abaa77937216600e2ae0431f2ce1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2f139e4"; rev="2f139e40c6c3abaa77937216600e2ae0431f2ce1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2f139e4"; rev="2f139e40c6c3abaa77937216600e2ae0431f2ce1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2f139e4"; rev="2f139e40c6c3abaa77937216600e2ae0431f2ce1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2f139e4"; rev="2f139e40c6c3abaa77937216600e2ae0431f2ce1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2f139e4"; rev="2f139e40c6c3abaa77937216600e2ae0431f2ce1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@sternenseemann sternenseemann deleted the sternenseemann:unbreak-utc branch Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.